Skip to content

fix(frontend): call toBeDefined() matcher to clear eslint no-unused-expressions #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 2 commits into from
Jul 9, 2026
Merged

fix(frontend): call toBeDefined() matcher to clear eslint no-unused-expressions #1357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59ce979
fix(frontend): call toBeDefined() matcher to clear eslint no-unused-e…
cristim Jul 5, 2026
6900476
test(frontend): assert submit handler is actually wired, not just non…
cristim Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions frontend/src/__tests__/users.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1855,10 +1855,18 @@ describe('users/handlers', () => {
});

it('should set up form submit handler', () => {
// saveUser is wired via addEventListener('submit', ...), so form.onsubmit
// stays null. Prove the listener is actually attached by spying on saveUser
// and dispatching a real submit event, then asserting the observable call.
const saveUserSpy = jest.spyOn(userModals, 'saveUser').mockResolvedValue(undefined);

userHandlers.setupUserHandlers();

const form = document.getElementById('user-form');
expect(form?.onsubmit || form?.getAttribute('data-handler')).toBeDefined;
const form = document.getElementById('user-form') as HTMLFormElement;
form.dispatchEvent(new Event('submit', { bubbles: true, cancelable: true }));

expect(saveUserSpy).toHaveBeenCalledTimes(1);
saveUserSpy.mockRestore();
});

it('should set up search input handler', () => {
Expand Down
Loading