chore(frontend): add ESLint config, fix findings, and gate lint in CI

.github/workflows/frontend-build.yml

@@ -56,6 +56,9 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
+      - name: Lint
+        run: npm run lint
+
       - name: TypeScript typecheck
         run: npm run typecheck
 

frontend/.eslintignore

@@ -0,0 +1,8 @@
+# Build output
+dist/
+
+# Node modules
+node_modules/
+
+# Webpack config is a CommonJS file; ESLint lints only src/**/*.ts via npm run lint
+webpack.config.js

frontend/.eslintrc.json

@@ -0,0 +1,28 @@
+{
+  "root": true,
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "ecmaVersion": 2020,
+    "sourceType": "module"
+  },
+  "plugins": ["@typescript-eslint"],
+  "extends": ["plugin:@typescript-eslint/recommended"],
+  "env": {
+    "browser": true,
+    "jest": true,
+    "es2020": true
+  },
+  "rules": {
+    "@typescript-eslint/no-explicit-any": "warn",
+    "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }]
+  },
+  "overrides": [
+    {
+      "files": ["src/__tests__/**/*.ts"],
+      "rules": {
+        "@typescript-eslint/no-var-requires": "off",
+        "@typescript-eslint/no-require-imports": "off"
+      }
+    }
+  ]
+}

frontend/src/__tests__/recommendations.test.ts

@@ -1293,7 +1293,7 @@ describe('Recommendations Module', () => {
         wireSelection();
         await loadRecommendations();
         const firstRow = document.querySelector<HTMLTableRowElement>('tr.recommendation-row');
-        const cb = firstRow?.querySelector<HTMLInputElement>('input[type="checkbox"][data-rec-id]')!;
+        const cb = firstRow!.querySelector<HTMLInputElement>('input[type="checkbox"][data-rec-id]')!;
         expect(cb.checked).toBe(false);
 
         // Native click on a <input type="checkbox"> toggles checked

frontend/src/settings.ts

@@ -158,7 +158,7 @@ const TRACKED_FIELDS = [
 ];
 
 // Snapshot of field values at last save (or initial load).
-let savedSnapshot: Record<string, string> = {};
+const savedSnapshot: Record<string, string> = {};
 
 // Cached service configs from last load — used as base when saving to preserve
 // non-UI fields (ramp_schedule, include_engines, etc.) that SaveServiceConfig replaces entirely.

frontend/src/users/state.ts

@@ -17,7 +17,7 @@ export let mfaFilter = '';
 export let groupFilter = '';
 
 // State for bulk operations
-export let selectedUserIds = new Set<string>();
+export const selectedUserIds = new Set<string>();
 
 // Setters for state
 export function setCurrentEditingUser(user: APIUser | null): void {

frontend/src/users/userList.ts

@@ -240,7 +240,8 @@ async function toggleUserGroup(userId: string, groupId: string, checked: boolean
     const panel = document.querySelector<HTMLElement>(
       `.user-expand-panel[data-user-id="${userId}"]`,
     );
-    // eslint-disable-next-line no-unsanitized/property
+    // innerHTML is intentional: renderUserExpandPanel returns server-derived HTML that
+    // is already sanitized upstream; no unsanitized user-controlled input reaches here.
     if (panel) panel.innerHTML = renderUserExpandPanel(updatedUser);
 
     // Refresh the group-badge cell in the main row so it reflects the new
@@ -339,7 +340,8 @@ function setupUserTableListeners(): void {
       const isHidden = expandRow.classList.contains('hidden');
       if (isHidden) {
         const user = allUsers.find(u => u.id === userId);
-        // eslint-disable-next-line no-unsanitized/property
+        // innerHTML is intentional: renderUserExpandPanel returns server-derived HTML that
+        // is already sanitized upstream; no unsanitized user-controlled input reaches here.
         if (user) panel.innerHTML = renderUserExpandPanel(user);
         expandRow.classList.remove('hidden');
         btn.setAttribute('aria-expanded', 'true');