Repository navigation
docs(readme): drop unsupported/nonsensical service-commitment rows - #1133
Conversation
GCP Cloud Storage does not offer Committed Use Discounts. The cloudstorage PurchaseCommitment returns ErrCommitmentPurchaseNotSupported with an explicit comment that GCS has no CUD or commitment purchase API. Remove "Cloud Storage | Committed Use Discounts" from the GCP table. Add three Azure services that are implemented in code but were missing from the README table: Azure Managed Redis (providers/azure/services/ managedredis), Azure Savings Plans (providers/azure/services/savingsplans), and Azure Synapse Analytics (providers/azure/services/synapse). All three are registered in AzureProvider.GetSupportedServices() and wired in newServiceClientForSubscription.
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Warning Review limit reached
More reviews will be available in 25 minutes and 48 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughREADME.md is updated to document additional Azure service commitment types and refine GCP service coverage in the service compatibility tables. ChangesService Compatibility Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Lambda and DynamoDB have no dedicated RI/Savings-Plan/commitment product to optimize, so listing them as contributable services is misleading. Reword to commitment-eligible services. Also drop the stale Terraform/CloudFormation line (the project deploys via Terraform; CloudFormation is not used).
docs(readme): drop unsupported/nonsensical service-commitment rows
Summary
providers/gcp/services/cloudstorage/client.goPurchaseCommitmentreturnsErrCommitmentPurchaseNotSupportedwith the comment "GCP Cloud Storage offers no committed-use discount or commitment purchase API". The recommender integration callsgoogle.storage.bucket.CostRecommenderwhich delivers storage-class optimization recommendations, not CUDs.providers/azure/services/managedredis/), Azure Savings Plans (providers/azure/services/savingsplans/), and Azure Synapse Analytics (providers/azure/services/synapse/). All three are registered inAzureProvider.GetSupportedServices()and wired innewServiceClientForSubscriptioninproviders/azure/provider.go.Per-row verdict
AWS Services (all kept -- implementation confirmed)
providers/aws/services/rds/providers/aws/services/elasticache/providers/aws/services/ec2/providers/aws/services/opensearch/providers/aws/services/redshift/providers/aws/services/memorydb/providers/aws/services/savingsplans/Azure Services (3 added -- previously missing)
providers/azure/services/database/providers/azure/services/compute/providers/azure/services/cache/providers/azure/services/cosmosdb/providers/azure/services/search/providers/azure/services/managedredis/providers/azure/services/savingsplans/providers/azure/services/synapse/GCP Services (1 removed)
providers/gcp/services/computeengine/providers/gcp/services/cloudsql/providers/gcp/services/memorystore/PurchaseCommitmentreturnsErrCommitmentPurchaseNotSupportedTest plan
providers/AzureProvider.GetSupportedServices()outputSummary by CodeRabbit