Skip to content

docs(readme): drop unsupported/nonsensical service-commitment rows - #1133

Merged
cristim merged 2 commits into
mainfrom
docs/curate-readme-services
Jun 9, 2026
Merged

cristim merged 2 commits into
mainfrom
docs/curate-readme-services

Conversation

@cristim

@cristim cristim commented Jun 9, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Remove GCP Cloud Storage | Committed Use Discounts from the GCP Services table. Cloud Storage is not CUD-eligible: providers/gcp/services/cloudstorage/client.go PurchaseCommitment returns ErrCommitmentPurchaseNotSupported with the comment "GCP Cloud Storage offers no committed-use discount or commitment purchase API". The recommender integration calls google.storage.bucket.CostRecommender which delivers storage-class optimization recommendations, not CUDs.
  • Add three Azure services that are implemented in code but were absent from the Azure Services table: Azure Managed Redis (providers/azure/services/managedredis/), Azure Savings Plans (providers/azure/services/savingsplans/), and Azure Synapse Analytics (providers/azure/services/synapse/). All three are registered in AzureProvider.GetSupportedServices() and wired in newServiceClientForSubscription in providers/azure/provider.go.

Per-row verdict

AWS Services (all kept -- implementation confirmed)

Service Commitment Real? Code? Action
Amazon RDS Reserved Instances Yes providers/aws/services/rds/ Keep
Amazon ElastiCache Reserved Nodes Yes providers/aws/services/elasticache/ Keep
Amazon EC2 Reserved Instances Yes providers/aws/services/ec2/ Keep
Amazon OpenSearch Reserved Instances Yes providers/aws/services/opensearch/ Keep
Amazon Redshift Reserved Nodes Yes providers/aws/services/redshift/ Keep
Amazon MemoryDB Reserved Nodes Yes providers/aws/services/memorydb/ Keep
Savings Plans Hourly Commitments Yes providers/aws/services/savingsplans/ Keep

Azure Services (3 added -- previously missing)

Service Commitment Real? Code? Action
Azure SQL Database Reserved Capacity Yes providers/azure/services/database/ Keep
Azure Virtual Machines Reserved Instances Yes providers/azure/services/compute/ Keep
Azure Cache for Redis Reserved Capacity Yes providers/azure/services/cache/ Keep
Azure Cosmos DB Reserved Capacity Yes providers/azure/services/cosmosdb/ Keep
Azure Cognitive Search Reserved Capacity Yes providers/azure/services/search/ Keep
Azure Managed Redis Reserved Capacity Yes providers/azure/services/managedredis/ Added (was missing)
Azure Savings Plans Hourly Commitments Yes providers/azure/services/savingsplans/ Added (was missing)
Azure Synapse Analytics Reserved Capacity Yes providers/azure/services/synapse/ Added (was missing)

GCP Services (1 removed)

Service Commitment Real? Code? Action
Compute Engine Committed Use Discounts Yes providers/gcp/services/computeengine/ Keep
Cloud SQL Committed Use Discounts Yes providers/gcp/services/cloudsql/ Keep
Memorystore Committed Use Discounts Yes providers/gcp/services/memorystore/ Keep
Cloud Storage Committed Use Discounts No -- GCS has no CUD product Code exists but PurchaseCommitment returns ErrCommitmentPurchaseNotSupported Removed

Test plan

  • Verify README renders correctly on GitHub (tables display, no broken markdown)
  • Confirm all kept rows have corresponding service directories under providers/
  • Confirm removed Cloud Storage row is absent
  • Confirm three new Azure rows match AzureProvider.GetSupportedServices() output

Summary by CodeRabbit

  • Documentation
    • Updated Azure (Experimental) supported services documentation with new commitment types for Managed Redis, Savings Plans, and Synapse Analytics.
    • Updated GCP (Experimental) supported services documentation by adjusting Cloud Storage commitment type information.

GCP Cloud Storage does not offer Committed Use Discounts. The
cloudstorage PurchaseCommitment returns ErrCommitmentPurchaseNotSupported
with an explicit comment that GCS has no CUD or commitment purchase API.
Remove "Cloud Storage | Committed Use Discounts" from the GCP table.

Add three Azure services that are implemented in code but were missing
from the README table: Azure Managed Redis (providers/azure/services/
managedredis), Azure Savings Plans (providers/azure/services/savingsplans),
and Azure Synapse Analytics (providers/azure/services/synapse). All three
are registered in AzureProvider.GetSupportedServices() and wired in
newServiceClientForSubscription.
@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship effort/s Hours type/docs Documentation labels Jun 9, 2026
@cristim

cristim commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ba0ba64-e115-411c-9028-f0d9d6749299

📥 Commits

Reviewing files that changed from the base of the PR and between 77acab7 and aeebf3e.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

README.md is updated to document additional Azure service commitment types and refine GCP service coverage in the service compatibility tables.

Changes

Service Compatibility Documentation

Layer / File(s) Summary
Service table expansion
README.md
Azure (Experimental) services table is extended with commitment type entries for Azure Managed Redis, Azure Savings Plans, and Azure Synapse Analytics. Cloud Storage is removed from the documented GCP (Experimental) services.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A table grows with Azure's gleam,
Redis, Plans, and Synapse stream,
While GCP loses Cloud's grand sight,
The docs now shine so pure and bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing an unsupported GCP Cloud Storage row and adding three missing Azure service rows to the README services documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/curate-readme-services

Comment @coderabbitai help to get the list of available commands and usage tips.

Lambda and DynamoDB have no dedicated RI/Savings-Plan/commitment product to optimize, so listing them as contributable services is misleading. Reword to commitment-eligible services. Also drop the stale Terraform/CloudFormation line (the project deploys via Terraform; CloudFormation is not used).
@cristim
cristim merged commit 03c9a2b into main Jun 9, 2026
8 of 17 checks passed
@cristim
cristim deleted the docs/curate-readme-services branch July 27, 2026 11:09
cristim added a commit that referenced this pull request Sep 27, 2026
docs(readme): drop unsupported/nonsensical service-commitment rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours priority/p3 Polish / idea / may never ship triaged Item has been triaged type/docs Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant