[cristim]

Summary

Fixes five robustness/correctness gaps in the deploy, accounts, and iacfiles packages. Closes #1057.

07-M4 -- nil-deref panic in EmptyBucket (Medium)

internal/deploy/frontend.go: *delErr.Key and *delErr.Message were dereferenced unconditionally inside the S3 per-object error loop. Both fields are *string and can be nil (e.g. an error with only Code set). Fix: aws.ToString() for both, which the package already imported.

Regression test: TestFrontendService_EmptyBucket_PerObjectErrorNilFields exercises this with nil Key/Message and confirms no panic.

07-L1 -- Dead Errors field in OrgDiscoveryResult (Low)

internal/accounts/org_discovery.go: OrgDiscoveryResult.Errors []error was declared but never populated and no caller read it. Discovery is all-or-nothing. The dead field implied partial-success semantics that did not exist. Removed.

07-L4 -- Duplicate base64-decode logic in LoginToPublicECR (Low)

internal/deploy/ecr.go: LoginToPublicECR inlined the same base64.StdEncoding.DecodeString + SplitN(":", 2) + parts[1] logic already encapsulated by decodeBase64Token, with a less precise error message. Refactored to call decodeBase64Token and delete the inline copy.

07-N1 -- Docker tag/name passed without validation (Nit)

internal/deploy/docker.go: Added validateDockerRef with ^[A-Za-z0-9][A-Za-z0-9._/:@-]*$. First character must be alphanumeric so leading hyphens (which docker interprets as flags) are rejected. Applied to BuildImage, TagImage, and PushImage.

07-N3 -- IaC templates interpolate user-controlled fields into shell scripts (Nit)

internal/iacfiles/embed.go: Added a security note to the package doc documenting that text/template performs no shell escaping and that the renderer (handler_federation.go) owns validation of user-controlled fields. Added TestCLITemplatesShellMetacharsPassThrough to confirm the pass-through behavior and document the renderer's responsibility.

Verification

go build ./...                                    # Success
go vet ./internal/deploy/... ./internal/accounts/... ./internal/iacfiles/...  # No issues
go test ./internal/deploy/... ./internal/accounts/... ./internal/iacfiles/...  # 115 passed

No live Postgres required; all covered by unit tests with mock clients.

Open questions for reviewer

• 07-N3: Please confirm that ContactEmail, AccountName, CUDlyAPIURL, and AccountSlug are validated/quoted at the API boundary in handler_federation.go before template.Execute. If not, a follow-up fix is needed there.

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 11 minutes and 38 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4760dd08-14c5-4d44-b3f6-fad52a20d73f

📥 Commits

Reviewing files that changed from the base of the PR and between cbdc4be and 700be11.

📒 Files selected for processing (9)

• internal/accounts/org_discovery.go
• internal/deploy/docker.go
• internal/deploy/docker_test.go
• internal/deploy/ecr.go
• internal/deploy/ecr_test.go
• internal/deploy/frontend.go
• internal/deploy/frontend_test.go
• internal/iacfiles/embed.go
• internal/iacfiles/templates_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/services-misc-cleanup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.