Skip to content

feat(user-mgmt): clarify group permissions combine via union (closes #1001) - #1008

Merged
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
feat/1001-group-union-hint
Jun 6, 2026
Merged

cristim merged 1 commit into
feat/multicloud-web-frontendfrom
feat/1001-group-union-hint

Conversation

@cristim

@cristim cristim commented Jun 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a one-line helper note in the User Management group-assignment expand panel explaining that a user's effective permissions are the union of all their groups' permissions, so assigning a lower-privilege group alongside a higher-privilege one is redundant, not contradictory.
  • No blocking or mutual-exclusion logic added -- working-as-designed per question(user-mgmt): should contradictory group combinations be blocked? #1001 Option A decision.
  • Two unit tests added asserting the hint text is rendered in .expand-panel-groups after the expand button is clicked.

Changes

frontend/src/users/userList.ts (renderUserExpandPanel): one new <p class="text-muted"> line after the <h5>Group Membership</h5> heading, using only the HTML entity &#8217; (right-single-quote) -- static text, no dynamic data injection.

frontend/src/__tests__/users.test.ts: new describe('group union permission hint (issue #1001)') block with two tests.

Test plan

  • npm run build -- clean (pre-existing entrypoint-size warning only)
  • npx tsc --noEmit -- no errors
  • npm test -- --testPathPattern=users.test -- 206/206 pass, including the two new tests
  • Open a user row in the User Management UI and verify the hint appears below the "Group Membership" heading

closes #1001

…1001)

Add a brief helper note in the Group Membership expand panel explaining
that a user's effective permissions are the union of all their groups'
permissions, so assigning a lower-privilege group alongside a
higher-privilege one has no effect (only redundancy, no conflict).

No blocking/mutual-exclusion logic added; working-as-designed per #1001
Option A decision.

Also add two unit tests asserting the hint text is rendered in the panel.
@cristim cristim added triaged Item has been triaged status/needs-info Awaiting clarification from the asker type/question Question for the project / asker labels Jun 6, 2026
@cristim

cristim commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 17 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa23b7a2-ba90-4fc1-b743-a31e45178718

📥 Commits

Reviewing files that changed from the base of the PR and between 3405060 and 5cb13d9.

📒 Files selected for processing (2)
  • frontend/src/__tests__/users.test.ts
  • frontend/src/users/userList.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/1001-group-union-hint

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
cristim merged commit 53cc077 into feat/multicloud-web-frontend Jun 6, 2026
6 checks passed
@cristim
cristim deleted the feat/1001-group-union-hint branch July 27, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-info Awaiting clarification from the asker triaged Item has been triaged type/question Question for the project / asker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant