Skip to content

chore(ci): add guard against password handlers that skip base64-decode (regression class of #356) #661

Closed

Description

@cristim

PR #357 (closed #356, P0) fixed a bug where the resetPassword API handler forgot to base64-decode new_password, locking out invited users. PR #357 noted that a CI guard against this class of bug (a handler that accepts a password but skips the decode step) was deferred as a follow-up, but no issue was filed.

Scope:

Out of scope when deferred: PR #357 was a targeted P0 fix; the systemic guard is a separate, lower-priority hardening item.

Deferred by: #357
Related: #356 (the original bug, fixed).

Activity

  1. added a commit that references this issue on May 27, 2026
    c792272
  2. cristim commented on May 28, 2026

    @cristim
    MemberAuthor

    Verified shipped on feat/multicloud-web-frontend via PR #722 (merged 2026-05-27). AST-based CI scanner (TestBase64PasswordGuard) now fails the build if any handler that json-unmarshals a request body and reads a .Password field does not call decodeBase64Password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions