Skip to content

chore(purchases): finish-or-remove GetPendingExecutionsTx (dead after #1037 chose per-row CAS) #1072

Closed as not planned
Closed as not planned
chore(purchases): finish-or-remove GetPendingExecutionsTx (dead after #1037 chose per-row CAS)#1072
Labels
effort/xsTrivial / one-linerimpact/internalTeam-internal onlypriority/p3Polish / idea / may never shiptriagedItem has been triagedtype/choreMaintenance / non-user-visibleurgency/this-quarterWithin the quarter

Description

@cristim
cristim
opened on Jun 7, 2026

Background

PR #1037 chose per-row CAS (TransitionExecutionStatus) for atomic claim-then-execute. Intentional and sound design.

GetPendingExecutionsTx was written for an alternative serialisable-transaction design that was superseded.

Problem

GetPendingExecutionsTx (and its tx-based locking scaffolding) became dead code after #1037 landed.

Options

  1. Remove if confirmed dead.
  2. Document as future hook for batch-claim scenarios.

Note

The #1037 CAS choice is intentional and sound. Do not revisit without a separate ADR. This chore is purely cleanup.

Files: internal/config/store_postgres.go (GetPendingExecutionsTx)

Activity

  1. cristim
    added
    triagedItem has been triaged
    priority/p3Polish / idea / may never ship
    urgency/this-quarterWithin the quarter
    impact/internalTeam-internal only
    effort/xsTrivial / one-liner
    type/choreMaintenance / non-user-visible
    on Jun 7, 2026

  2. cristim commented on Jun 8, 2026

    @cristim
    cristim
    on Jun 8, 2026 – with Claude
    MemberAuthor

    Closing as not_planned: GetPendingExecutionsTx is not dead code. It is actively called at internal/api/handler_purchases.go:1508 inside the executePurchase WithTx block, which is exactly the TOCTOU-closing role the comment describes. The function was either re-adopted after #1037 or the issue was filed against an intermediate state. Either way, removing it would break the duplicate-detection path.

    Generated by Claude Code

  3. cristim
    closed this as not plannedon Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort/xsTrivial / one-linerimpact/internalTeam-internal onlypriority/p3Polish / idea / may never shiptriagedItem has been triagedtype/choreMaintenance / non-user-visibleurgency/this-quarterWithin the quarter

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions