You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(gcp): converter never sets Count/SavingsPct/Cost — CUD purchase requests 0 vCPU; scorer drops all GCP recs #1022
Problem.convertGCPRecommendation (all four GCP services) sets only EstimatedSavings and leaves Count, SavingsPercentage, CommitmentCost, OnDemandCost, BreakEvenMonths at zero.
C1:buildInsertRequest (computeengine/client.go:507-540) does Amount: int64(rec.Count) (and *4096 for memory) → a Recommender-driven purchase requests a 0 vCPU / 0 MB commitment. Green tests hide it (they hand-build Recommendation{Count:N}).
C2:pkg/scorer filters on SavingsPercentage (MinSavingsPct), BreakEvenMonths, Count (MinCount) — all zero for GCP → any non-zero filter silently drops all GCP recs; when they pass they rank to the bottom.
Evidence.computeengine/client.go:795-811 (converter), :507-540 (insert); pkg/scorer/scorer.go:80-90. GCP pricing fns compute the numbers but are only called from GetOfferingDetails, never the converter.
Suggested fix. Extract vCPU count from the Recommender payload → set rec.Count; thread the pricing path into the converter to fill CommitmentCost/OnDemandCost/SavingsPercentage/BreakEvenMonths. Guard buildInsertRequest/PurchaseCommitment to refuse rec.Count <= 0. Also fix 10-M5 (per-service hardcoded PaymentOption — see #718/#829 for the monthly-stamp part). Regression test: realistic Recommender response → converter → Count > 0 and VCPU Amount set; through scorer with MinSavingsPct set, GCP recs survive.
Activity
fix(gcp/computeengine): use valid MEMORY resource enum on CUD insert (#…
fix(gcp): wire Count/pricing into GCP converters; refuse fabricated p…
fix(gcp): select the machine-type op; refuse accelerator CUDs
fix(gcp): derive CUD commitment type from machine family
fix(gcp): select the machine-type op; refuse accelerator CUDs
fix(gcp): derive CUD commitment type from machine family (#1650)