fix(include): require opt-in for remote includes - #262
Merged
Merged
Conversation
53 tasks
LeadcodeDev
force-pushed
the
fix/expand-node-budget
branch
from
September 22, 2026 06:11
62393d5 to
4dc047f
Compare
LeadcodeDev
force-pushed
the
fix/remote-include-optin
branch
from
September 22, 2026 06:11
1a96e5a to
b24e80d
Compare
LeadcodeDev
force-pushed
the
fix/expand-node-budget
branch
from
September 22, 2026 08:36
4dc047f to
9daff5f
Compare
LeadcodeDev
force-pushed
the
fix/remote-include-optin
branch
from
September 22, 2026 08:36
b24e80d to
4149673
Compare
LeadcodeDev
force-pushed
the
fix/expand-node-budget
branch
from
September 22, 2026 08:46
9daff5f to
226b364
Compare
LeadcodeDev
force-pushed
the
fix/remote-include-optin
branch
from
September 22, 2026 08:46
4149673 to
7151be0
Compare
LeadcodeDev
changed the base branch from
fix/expand-node-budget
to
chantier/audit-2026-09
September 22, 2026 08:54
LeadcodeDev
force-pushed
the
fix/remote-include-optin
branch
from
September 22, 2026 09:02
7151be0 to
da2106a
Compare
Any scenario handed to `rustmotion render`/`validate` can make the user's machine issue GETs to hosts of the author's choosing, with no host/scheme allowlist, no redirect policy, no timeout set on the call, and no `--offline` switch to refuse. On a developer laptop or a CI runner this reaches loopback services, RFC1918 addresses and cloud link-local metadata (169.254.169.254), and it doubles as a silent beacon that fires merely from *validating* a file (validation::load goes through the same `resolve_includes`). Fetching remote includes is clearly deliberate design, so the finding is the absence of any control around it, not the feature. Refs #220
LeadcodeDev
force-pushed
the
fix/remote-include-optin
branch
from
September 22, 2026 09:06
da2106a to
915a105
Compare
LeadcodeDev
added a commit
that referenced
this pull request
Sep 22, 2026
Any scenario handed to `rustmotion render`/`validate` can make the user's machine issue GETs to hosts of the author's choosing, with no host/scheme allowlist, no redirect policy, no timeout set on the call, and no `--offline` switch to refuse. On a developer laptop or a CI runner this reaches loopback services, RFC1918 addresses and cloud link-local metadata (169.254.169.254), and it doubles as a silent beacon that fires merely from *validating* a file (validation::load goes through the same `resolve_includes`). Fetching remote includes is clearly deliberate design, so the finding is the absence of any control around it, not the feature. Refs #220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Severity Low, category security. Location:
crates/rustmotion/src/include.rs:220Impact
Any scenario handed to
rustmotion render/validatecan make the user's machine issue GETs to hosts of the author's choosing, with no host/scheme allowlist, no redirect policy, no timeout set on the call, and no--offlineswitch to refuse. On a developer laptop or a CI runner this reaches loopback services, RFC1918 addresses and cloud link-local metadata (169.254.169.254), and it doubles as a silent beacon that fires merely from validating a file (validation::load goes through the sameresolve_includes). Fetching remote includes is clearly deliberate design, so the finding is the absence of any control around it, not the feature.Fix
Gate remote includes behind an explicit opt-in flag (default deny), and when enabled reject non-public destinations after DNS resolution (loopback, link-local, RFC1918/ULA), set an explicit timeout, and cap the response size. Report the URLs a scenario wants to fetch before fetching them.
Evidence the audit read
Part of the September 2026 audit remediation chantier. Refs #220 (RM-46).