fix(assets): restrict the protocols a scenario src may use - #260
Closed
LeadcodeDev wants to merge 1 commit into
Closed
LeadcodeDev wants to merge 1 commit into
LeadcodeDev wants to merge 1 commit into
Conversation
53 tasks
LeadcodeDev
force-pushed
the
fix/http-timeout
branch
from
September 22, 2026 06:11
c01dbe5 to
268592c
Compare
LeadcodeDev
force-pushed
the
fix/media-protocol-allowlist
branch
from
September 22, 2026 06:11
3e4b39f to
e9965fc
Compare
LeadcodeDev
force-pushed
the
fix/http-timeout
branch
from
September 22, 2026 08:36
268592c to
fa7b242
Compare
LeadcodeDev
force-pushed
the
fix/media-protocol-allowlist
branch
from
September 22, 2026 08:36
e9965fc to
edd1852
Compare
LeadcodeDev
force-pushed
the
fix/http-timeout
branch
from
September 22, 2026 08:45
fa7b242 to
1878d51
Compare
src is the video component's scenario field, unfiltered. info.rs:385-391
documents this explicitly ("video's ffmpeg-backed path only reaches one
incidentally by handing the string straight to ffmpeg's own demuxer") — so
the network reach is acknowledged as accidental, not designed. ffmpeg is
invoked without -protocol_whitelist, which means the scenario selects from
ffmpeg's entire built-in protocol set: src:
"http://169.254.169.254/latest/meta-data/" or http://127.0.0.1:8500/...
makes the renderer issue that request (SSRF from an LLM-authored scenario,
and a reliable internal port-scan oracle via the exit status printed at
preload.rs:252-258). The same unfiltered string reaches preload.rs:221-222
and encode/video_audio.rs:326-327. Secondary risk: playlist/subtitle
demuxers that dereference nested file: URLs would render local file content
into the output video. There is no timeout on the subprocess either, so a
slow remote URL stalls the render.
Fix: Add -protocol_whitelist file (plus ,http,https,tcp,tls only if remote
video is a supported feature) to all three ffmpeg argument lists, and
validate src against the same scheme check rustmotion/src/assets.rs:26
already uses before the string ever reaches Command. Reject anything that is
neither a plain local path nor an explicitly allowed scheme.
Refs #220
LeadcodeDev
force-pushed
the
fix/media-protocol-allowlist
branch
from
September 22, 2026 08:45
edd1852 to
50f6268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Severity Low, category security. Location:
crates/rustmotion-core/src/engine/renderer/assets.rs:222Impact
srcis thevideocomponent's scenario field, unfiltered.info.rs:385-391documents this explicitly ("video's ffmpeg-backed path only reaches one incidentally by handing the string straight to ffmpeg's own demuxer") — so the network reach is acknowledged as accidental, not designed. ffmpeg is invoked without-protocol_whitelist, which means the scenario selects from ffmpeg's entire built-in protocol set:src: "http://169.254.169.254/latest/meta-data/"orhttp://127.0.0.1:8500/...makes the renderer issue that request (SSRF from an LLM-authored scenario, and a reliable internal port-scan oracle via the exit status printed at preload.rs:252-258). The same unfiltered string reachespreload.rs:221-222andencode/video_audio.rs:326-327. Secondary risk: playlist/subtitle demuxers that dereference nestedfile:URLs would render local file content into the output video. There is no timeout on the subprocess either, so a slow remote URL stalls the render.Fix
Add
-protocol_whitelist file(plus,http,https,tcp,tlsonly if remote video is a supported feature) to all threeffmpegargument lists, and validatesrcagainst the same scheme checkrustmotion/src/assets.rs:26already uses before the string ever reachesCommand. Reject anything that is neither a plain local path nor an explicitly allowed scheme.Evidence the audit read
Part of the September 2026 audit remediation chantier. Refs #220 (RM-42).