fix(extension): name the missing dependency when Windows load fails#704
Closed
freya0926 wants to merge 2 commits into
Closed
fix(extension): name the missing dependency when Windows load fails#704freya0926 wants to merge 2 commits into
freya0926 wants to merge 2 commits into
Conversation
Windows raises ERROR_MOD_NOT_FOUND against the library passed to LoadLibraryW, so a missing transitive dependency is reported as "the specified module could not be found" naming the extension -- which is present. Users are left guessing which module is meant. When the extension file itself exists, say that the missing module is something it links against and name the OpenSSL 3 DLLs, which are the usual culprits on Windows. Refs LadybugDB#685
Contributor
|
Closing based on no bots policy. Humans generating AI assisted PRs is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows reports a missing transitive dependency as
ERROR_MOD_NOT_FOUNDagainst the library passed toLoadLibraryW, soLOAD EXTENSION ftson a machine without OpenSSL 3 fails with "the specified module could not be found" — naming the extension, which is present. Users are left guessing which module is actually meant (#685).When the extension file itself exists, this adds a line saying the missing module is something the extension links against, and names the OpenSSL 3 DLLs.
Scope: this only improves the message. It does not fix #685 — @adsharma confirmed the core links OpenSSL dynamically, which means the core has already loaded
libssl-3-x64.dllbefore any extension loads, so the fix for the underlying packaging problem belongs elsewhere.Testing: compiles clean on MSVC 14.44 (VS 2022 Build Tools, Windows SDK 10.0.26100), full static Release build links. I could not exercise the message at runtime —
lbug_shell.exebuilt here crashes with0xC0000409on database open, which I confirmed is pre-existing by reproducing it with this change reverted.🤖 Generated with Claude Code