Fix SNPRC EHR setup for creating SND Categories#959
Merged
Conversation
labkey-martyp
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
SNPRC_EHRTestsetup was failing when SND categories already existed in the target folder —createSNDCategoriesunconditionally inserted every entry inSND_CATEGORIES, causing duplicate-key errors on re-runs. Also replaced a hand-builtpopulateData.viewURL withWebTestHelper.buildURL(...)so the action name is validated the same way as elsewhere in the suite.Related Pull Requests
Changes
createSNDCategoriesnow selects existing rows fromsnd.PkgCategoriesfirst and only inserts categories that are not already present; skips the insert entirely when there is nothing new to add.populateInitialDatabuilds itspopulateDataaction URL viaWebTestHelper.buildURL("SNPRC_EHR", getContainerPath(), "populateData")instead of concatenatinggetBaseURL()with a literal.viewpath.