GitHub Issue 1188: Stop JDBC caching by default in QueryService#7708
Merged
Conversation
The test was migrated from getSelectSQL(..., 1000, 0, true) to getSelectBuilder().buildSqlFragment() but lost the forceSort=true flag. Without it, the sort-resolution block (appendDefaultSort, sortFieldKeys resolution) is never entered, causing implicit sorts and B→C sortFieldKey substitutions to be skipped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 30, 2026
Merged
labkey-adam
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We can improve our memory usage by avoiding unwanted JDBC caching. We can also simplify
QueryServiceusage by consolidating to useSelectBuilder.Changes
QueryServicemethod likeselect()getSelectBuilder()andSelectBuilderpatterns