Continue enhancing SQL protections#7707
Open
labkey-jeckels wants to merge 9 commits into
Open
Conversation
labkey-matthewb
requested changes
Jun 1, 2026
|
|
||
| @Override | ||
| public String buildProcedureCall(String procSchema, String procName, int paramCount, boolean hasReturn, boolean assignResult, DbScope procScope) | ||
| protected String doBuildProcedureCall(String qualifiedProcName, int paramCount, boolean hasReturn, boolean assignResult, DbScope procScope) |
Contributor
There was a problem hiding this comment.
Should be (String schema, String proc) OR (SQLFragment qualifiedProcName)
Contributor
Author
There was a problem hiding this comment.
Switched to SQLFragment
labkey-matthewb
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Robust SQL generation is important. Code cleanup and consolidation is nice too.
Changes
Tasks 📍
Manual Testing