Skip to content

GitHub Issue 954: Add error for duplicate values for parent inputs #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XingY wants to merge 3 commits into
base: develop
Choose a base branch
from
+16 −1
Open

GitHub Issue 954: Add error for duplicate values for parent inputs #7559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
990aee8
GitHub Issue 954: Add error for duplicate values for parent inputs
XingY Apr 7, 2026
5668813
jest and api tests
XingY Apr 7, 2026
54a27d3
Merge remote-tracking branch 'origin/develop' into fb_duplicateParents
XingY Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion api/src/org/labkey/api/data/NameGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ protected int write()
.filter(s -> !s.isEmpty());
}

public static Stream<String> parentNames(Object value, String parentColName, TSVWriter tsvWriter, @Nullable BatchValidationException errors)
public static @Nullable Stream<String> parentNames(Object value, String parentColName, TSVWriter tsvWriter, @Nullable BatchValidationException errors)
{
if (value == null)
return Stream.empty();
Expand Down Expand Up @@ -783,6 +783,21 @@ else if (value instanceof JSONArray jsonArray)
throw new IllegalStateException("For parent values in naming pattern, expected string or collection for '" + parentColName + "': " + value);
}

if (values != null)
{
List<String> valueList = values.toList();
Set<String> valueSet = new HashSet<>();
List<String> duplicates = valueList.stream().filter(s -> !valueSet.add(s)).toList();
Copy link
Copy Markdown
Contributor

@labkey-susanh labkey-susanh Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion from the stream to the list to the stream and then again to the stream is, uh, unfortunate and kind of defeats one of the purposes of using the stream. I would hope that we don't have a lot of values, of course, so maybe not a big deal (and I don't have a better suggestion).

if (!duplicates.isEmpty())
{
if (errors != null)
errors.addRowError(new ValidationException("Duplicate parent names found: " + StringUtils.join(duplicates, ", "), parentColName));
else
throw new IllegalStateException("Duplicate parent names found: " + StringUtils.join(duplicates, ", "));
}
return valueList.stream();
}

return values;
}

Expand Down
Loading