[bot] Merge 26.3 to 26.4 (Conflicts)#7554
Open
github-actions[bot] wants to merge 5 commits intorelease26.4-SNAPSHOTfrom
Open
[bot] Merge 26.3 to 26.4 (Conflicts)#7554github-actions[bot] wants to merge 5 commits intorelease26.4-SNAPSHOTfrom
github-actions[bot] wants to merge 5 commits intorelease26.4-SNAPSHOTfrom
Conversation
…abs (#7534) #### Rationale We are inappropriately tagging our folder portal tabs with `role="presentation"`. You're not allowed to use it on an `<li>` without a similar tag on a parent element like the `<ul>`. Since these tabs are full-page navigations instead of in-page replacements, it seems the most appropriate thing is to simply remove this incorrect attribute. https://www.w3.org/WAI/ARIA/apg/practices/hiding-semantics/ #### Changes - Remove `role="presentation"` from folder portal tabs - Signify the active tab using `aria-current="page"` <!-- list of standard tasks (remove this comment to enable) #### Tasks 📍 - [ ] Manual Testing - [ ] Needs Automation - [ ] Verify Fix -->
…igner (#7544) - update @labkey/components package version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic merge failed! Please merge
26.3into26.4_fb_bot_merge_26.3and resolve conflicts manually.Resolve all conflicts (using IntelliJ or
git mergetool)Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.4_fb_bot_merge_26.3