Allow registering multiple InvoicedItemsProcessingService impls#1102
Open
labkey-adam wants to merge 1 commit intodevelopfrom
Open
Allow registering multiple InvoicedItemsProcessingService impls#1102labkey-adam wants to merge 1 commit intodevelopfrom
labkey-adam wants to merge 1 commit intodevelopfrom
Conversation
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
Not sure if you were ready for code review on this. We'll need register calls then in the client repos?
| protected BillingTask(Factory factory, PipelineJob job) | ||
| { | ||
| super(factory, job); | ||
| _processingService = InvoicedItemsProcessingService.get(job.getContainer()); |
Contributor
There was a problem hiding this comment.
I think we'll want to use EHR_BillingManager.get().getBillingContainer(getJob().getContainer());
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/kanban/issues/1577
We need to allow multiple modules to register a
InvoicedItemsProcessingServiceimpl. Provide a module at registration time and a container at retrieval time. Determine the impl to return based on active modules in the container.Related Pull Requests