Track Instrument Changes in Journal#8208
Open
extern-stat wants to merge 1 commit intoLMMS:masterfrom
Open
Conversation
Contributor
|
I wanted to test but if I don't get the chance another maintainer can feel free to merge after confirming the fix works. |
Contributor
|
Just tested this one; it works, although it behaves a little strangely when the newly set instrument has active settings in the envelope/filter/LFO tab and/or effects. Probably because these create additional Journal checkpoints of their own. Try replacing a Zyn preset with e.g. the DetunedGhost preset for Triple Oscillator to see what I mean. You'll have to hit Undo a couple times to get back to the Zyn preset, but you do get back to it, and all EF/LFO settings and Effects are properly removed. |
Member
|
I'm worried about the memory footprint of this. That being said, I still haven't tested it but I'll get around to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1262 by making a journal checkpoint when a track's instrument changes. It sometimes requires multiple undos to undo an instrument change because some instruments create journal checkpoints upon being loaded, but that's a preexisting issue that's unrelated to this fix.