"Universal" workspace panning#8203
Conversation
szeli1
left a comment
There was a problem hiding this comment.
My concern with this PR is that it looks like to me that other "ctrl + alt" mouse shortcuts may not work because of the event filter. I did not test this PR.
Here is some code that may be effected:
AutomationEditor:
}
else if( we->modifiers() & Qt::ControlModifier && we->modifiers() & Qt::AltModifier )
{ClipView:
bool ClipView::unquantizedModHeld( QMouseEvent * me )
{
return me->modifiers() & Qt::ControlModifier || me->modifiers() & Qt::AltModifier;
}PianoRoll:
void PianoRoll::dragNotes(int x, int y, bool alt, bool shift, bool ctrl)Co-authored-by: szeli1 <143485814+szeli1@users.noreply.github.com>
|
Changed the keybinding to Also a note to self: adding the keybinding handling on the event filter is sadly necessary, as when it is pressed I have to prevent it from being forwarded to other elements. I tried implementing it with key{Press,Release}Event and it was a mess. |
If I remember correctly, there are other options like implementing it in |
This reverts commit b5e239b.
currently with a default of "no click"
|
Update! I've found some bugs introduced by this PR and reported them on the PR description. They are not critical (they are not irreversible) but they are a bit annoying sometimes. |
This PR adds the ability to pan through the workspace without having to click on free areas (i.e. the background). This is done primarily through holding
Alt-Sand dragging the area around (optionally clicking), but I've also put scrollbars back.2026-02-24.universal_panning_demo.v3.mp4
KNOWN BUGS:
Alt-S-Clicksometimes stops working (haven't managed to track down the cause yet).When testing, keep an eye out for whether the scroll bars are working properly and whether panning feels natural, or if it's error prone.
(Old) progress
Ctrl+Alt->Alt+SWhen loading a project, song editor will go over other windows. How to avoid that? Or at least remedy it. If the piano roll is maximized and open, for example, the song editor goes over and things get confusing.Not necessary for this PR