Feat/reasonix support - #2
Open
qazmlpwsxedc wants to merge 2 commits into
Open
Conversation
Reasonix has no `mcp add` CLI, so the academic-search fallback is registered by
appending a `[[plugins]]` entry to the Reasonix `config.toml` instead.
- setup_academic_mcp.py: add a `reasonix` client.
* `reasonix_home()` resolves REASONIX_HOME, then the platform default that
already holds a config.toml (%APPDATA%\reasonix on Windows, ~/.reasonix
elsewhere).
* `_detect_toml()` now recognises both `[mcp_servers.*]` and `[[plugins]]`,
on the tomllib path and the regex fallback (Python 3.8-3.10).
* `register_reasonix_plugin()` appends the entry through an atomic replace and
preserves the existing bytes, including line endings.
* `ensure_mcp()` gains a reasonix branch that never shells out, and keeps the
fail-closed behaviour: no `uv` means no write and no success report.
- install-reasonix.sh / install-reasonix.cmd: one-click deployment of the skill
into the Reasonix skills directory plus the MCP setup step.
- vendor/academic-search-mcp/.python-version: pin 3.12, because the fallback's
dependencies have no wheels for the newest CPython that uv would otherwise
select.
- README/README.zh-CN: document the Reasonix install path and how its MCP
registration differs from Codex and Claude Code.
- tests: reasonix home resolution, plugin detection, idempotent registration,
reuse of an existing registration, fail-closed without uv, line-ending
preservation and atomic writes; packaging checks cover the new installers.
install-reasonix.sh/.cmd selected the Reasonix home from directory existence, while setup_academic_mcp.py's reasonix_home() prefers the candidate that actually holds a config.toml. On a machine where %APPDATA%\reasonix exists without a config.toml, the two could disagree and deploy the skill into one directory while registering the MCP in another. Both installers now mirror the Python helper: prefer a candidate that contains config.toml, then fall back to the platform default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Describe the focused change and why it is needed.
Validation
git diff --checkpassesPrivacy review