Skip to content

DEMO ONLY, DO NOT MERGE: negative control for #473 (scenario gate must go red) - #474

Closed
Yaraslaut wants to merge 1 commit into
feat/462-scenario-ci-gatefrom
demo/462-gate-goes-red
Closed

DEMO ONLY, DO NOT MERGE: negative control for #473 (scenario gate must go red)#474
Yaraslaut wants to merge 1 commit into
feat/462-scenario-ci-gatefrom
demo/462-gate-goes-red

Conversation

@Yaraslaut

Copy link
Copy Markdown
Member

Negative control for #473 (morph#462). Do not merge. This will be closed once the evidence is captured.

Base is feat/462-scenario-ci-gate, so the checked-out tree carries #473's gate and its path filter.

The entire diff is one file under scripts/scenario/: categorise-an-account.scenario reverted to its pre-8a67ffe7 integer-enum spelling — the exact form morph#460 measured as 16-of-16 refused by a real ladder_ledger_server.

Two things this is meant to show at once:

  1. The gate goes red. ladder-tests -> "Run the scenario corpus against the built servers" must fail.
  2. The path filter reaches it. The whole diff is scripts/scenario/ only. Before ci: run the scenario corpus in ladder-tests, and let corpus changes reach it #473 that matched nothing in ladder_rungs.sh ci-path-regex and ladder-tests would have been skipped outright — the "Determine whether the ladder needs to run" step's log shows the pattern it used and run=true.

Then the file is restored on this same branch and the job must go green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01C6uB9zxdSG8qp3VNAAyFvF

…um spelling

Negative control for #473 / morph#462. Reverts
scripts/scenario/scenarios/ledger/categorise-an-account.scenario to its
pre-8a67ffe7 form, where every ledger enum is spelled as its underlying integer
-- the exact form morph#460 measured as 16-of-16 refused.

The whole diff of this pull request is one file under scripts/scenario/, so it
also demonstrates the second half of #473: before that change the ladder path
filter did not match scripts/scenario/ at all and `ladder-tests` would have been
skipped outright.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C6uB9zxdSG8qp3VNAAyFvF
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Yaraslaut

Copy link
Copy Markdown
Member Author

Evidence captured; closing. This was never for merging.

What it demonstrated, for #473 / morph#462:

  • Application ladder, run 34060255730failure, and the only failing step in the job was Run the scenario corpus against the built servers:

    FAIL step 5 (line 30): do OpenAccount ledgerId=1 name="Categorised cash" kind=0 currency=1
      expected: @kind == ok
      actual:   @kind == err
      reply:    err message="1:48: expected_quote ..."
    FAILED: ledger
    ##[error]Process completed with exit code 1.
    

    Build and ctest both passed in that same job, so the red is the corpus and nothing else. That is the negative control: the gate is shown red before it is trusted.

  • The path filter. This pull request's whole diff was one file under scripts/scenario/ and nothing else. On master today that matches no alternative in ladder_rungs.sh ci-path-regex, so ladder-tests would have been skipped outright — the job that caught this would have been absent from the change that broke it. With ci: run the scenario corpus in ladder-tests, and let corpus changes reach it #473's entry it ran. That it ran at all is the proof.

  • The green half is ci: run the scenario corpus in ladder-tests, and let corpus changes reach it #473's own run, 34060226868every scenario passed in: bookmarks, kanban, ledger, pastebin, polls (73 files) — against the same tree with this one file restored.

Both runs are quoted in full in #473's body. Branch demo/462-gate-goes-red is kept for now so those run URLs stay resolvable.

🤖 Generated with Claude Code

@Yaraslaut Yaraslaut closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant