fix: Fix tool-bridge slot leak when session.abort() throws inside runAgentTurn (#73)#77
Open
KochC wants to merge 1 commit into
Open
fix: Fix tool-bridge slot leak when session.abort() throws inside runAgentTurn (#73)#77KochC wants to merge 1 commit into
KochC wants to merge 1 commit into
Conversation
…hrows inside runAgentTurn Move all post-bridge-acquisition work in runAgentTurn() into a single outer try/finally that calls releaseToolBridge(bridge). Previously, session.create(), event.subscribe(), and session.promptAsync() were called *before* the inner try/finally that released the slot, so any throw in that window permanently lost the bridge slot from the pool. The outer try/finally guarantees the slot is returned even if these calls throw, preventing pool exhaustion. Also adds a regression test that fires 20 sequential requests with a always- failing session.create (more than the default pool size of 8) to confirm the pool is never exhausted when errors occur after bridge acquisition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrapped the entire post-bridge-acquisition body of runAgentTurn() in an outer try/finally that calls releaseToolBridge(bridge), so the pool slot is always returned even if session.create(), event.subscribe(), or session.promptAsync() throw before the event-loop is entered.
Closes #73
Diff
Automated fix by OpenCode Agent