Fix QuadPointEvaluator initialization issues#80
Open
MelanieInky wants to merge 4 commits into
Open
Conversation
Author
|
I copy pasted the logic from the function dispatching on ::AbstractDomainBuffer. The failing test now run successfully on my local machine but I am not sure I understand when exactly it will dispatch on ::AbstractDomainBuffer and if that function should be changed as well. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 96.82% 96.89% +0.06%
==========================================
Files 30 30
Lines 1166 1160 -6
==========================================
- Hits 1129 1124 -5
+ Misses 37 36 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KnutAM
reviewed
Jun 25, 2026
Co-authored-by: Knut Andreas Meyer <knutam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the changes as discussed in issue #76.