Repository navigation
Cleanup the accept HTTP header as GitHub no longer versions this - #1155
Open
nunoplopes wants to merge 1 commit into
Open
nunoplopes wants to merge 1 commit into
nunoplopes wants to merge 1 commit into
Conversation
acrobat
requested changes
Oct 23, 2026
| { | ||
| use AcceptHeaderTrait; | ||
|
|
||
| public function configure() |
Collaborator
There was a problem hiding this comment.
The configure method can not just be removed as this would be a BC break. Can you just empty the method, trigger a deprecation message so that users know don't need to call this method anymore and return $this.
We can cleanup these methods in the next major. Same for other configure method removals
Collaborator
|
Also do a rebase to resolve the conflicts! |
nunoplopes
force-pushed
the
accept_header
branch
from
October 25, 2026 22:11
d508be8 to
cbd9514
Compare
Contributor
Author
|
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this: https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api?apiVersion=2022-11-28#media-types
GitHub not longer versions the accept header. It uses this instead: https://docs.github.com/en/rest/about-the-rest-api/api-versions?apiVersion=2022-11-28
But since GitHub is only exposing a single API right now, there's no need for versioning. Plus, all the exported functions are available and are not in preview anymore.