Adds parsing of R dependencies from DESCRIPTION files#917
Open
codeZeilen wants to merge 2 commits intoKnowledgeCaptureAndDiscovery:devfrom
Open
Adds parsing of R dependencies from DESCRIPTION files#917codeZeilen wants to merge 2 commits intoKnowledgeCaptureAndDiscovery:devfrom
codeZeilen wants to merge 2 commits intoKnowledgeCaptureAndDiscovery:devfrom
Conversation
Collaborator
|
Awesome, thanks!!
The documentation for each parser is in the docs, indeed. It would be great
to adapt it so we push it in the next release.
Also, if you haven't done it already, please target the dev branch, as it's
where we have the latest code. Thanks again!!
El vie., 13 mar. 2026 4:47 p. m., Patrick R ***@***.***>
escribió:
… This PR only adds parsing of dependencies from DESCRIPTION files and
adapts the corresponding test.
I adapted both tests, as the two DESCRIPTION files in the test data
conveniently use two different formats of listing the requirements
(one-per-line vs multi-line).
Is there anything else that needs to be adapted (e.g., I have seen that
parsers are documented in docs)?
------------------------------
You can view, comment on, or merge this pull request online at:
#917
Commit Summary
- 992c9a5
<992c9a5>
Adds parsing of R dependencies from DESCRIPTION files
- 39ada7d
<39ada7d>
Extends R DESCRIPTION file parser test, removes debugging statement
File Changes
(2 files
<https://github.com/KnowledgeCaptureAndDiscovery/somef/pull/917/files>)
- *M* src/somef/parser/description_parser.py
<https://github.com/KnowledgeCaptureAndDiscovery/somef/pull/917/files#diff-dc6c3f5900a7ae9c3a707de3375971397cc16991ba9a381e8484b34b04731d19>
(24)
- *M* src/somef/test/test_description_parser.py
<https://github.com/KnowledgeCaptureAndDiscovery/somef/pull/917/files#diff-762a05cbc1f28b3a6d2a9e7e1f62f8224c42c0f92461fd1c7d88c79f525a11ef>
(26)
Patch Links:
- https://github.com/KnowledgeCaptureAndDiscovery/somef/pull/917.patch
- https://github.com/KnowledgeCaptureAndDiscovery/somef/pull/917.diff
—
Reply to this email directly, view it on GitHub
<#917>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGWUXSGFGBPXJLKEVRT4QQUSHAVCNFSM6AAAAACWRF32POVHI2DSMVQWIX3LMV43ASLTON2WKOZUGA3TCOJRGE4TCOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds parsing of dependencies from DESCRIPTION files and adapts the corresponding test.
I adapted both tests, as the two DESCRIPTION files in the test data conveniently use two different formats of listing the requirements (one-per-line vs multi-line).
Is there anything else that needs to be adapted (e.g., I have seen that parsers are documented in
docs)?