Skip to content

refactor(WebGL): remove support for WebGL1#3523

Open
daker wants to merge 1 commit into
Kitware:masterfrom
daker:remove-webgl1
Open

refactor(WebGL): remove support for WebGL1#3523
daker wants to merge 1 commit into
Kitware:masterfrom
daker:remove-webgl1

Conversation

@daker

@daker daker commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it compare with #2212 ?

I find it a bit misleading that claiming it remove WebGL1 support but it still render as in "WebGL1" would do, e.g. it duplicates points for each cells (see vtkCellArrayBufferObject). This is big bottleneck when it comes to rendering initialization and memory usage.

It can be done in a second pass though.

@daker

daker commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

@finetjul it's the same as #2212 but rebased. i get your point i will try to see if i can do something

@daker daker marked this pull request as draft June 4, 2026 10:47
@daker daker force-pushed the remove-webgl1 branch 3 times, most recently from ed41a54 to 8dd1af9 Compare June 16, 2026 14:39
@daker daker marked this pull request as ready for review June 21, 2026 16:47
@daker daker requested a review from finetjul June 23, 2026 19:46

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jo-Byr can you have a look at the WebGL2 implementation ?

@daker do you see an improvement of performance (TTFF)?

Comment thread Sources/Common/Core/CellArray/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants