Repository navigation
Fixes from the 0.7 rounds on the Mac and jura - #370
Merged
Merged
Conversation
Permutation takes (ids, base); the test gave (base, ids), so the six float values were ids into the three ids, read out of bounds alike by the host and the kernel. It passed in plain mode on the garbage both read; the suite under TACK_DEBUG=1 caught it. Now the ids come first, and the permutation's values are checked.
_vtk_data.path fetches what it is given: the empty .foam alone left the case's other files unfetched and the reader without a case.
The nightly wheels have DLPack and Viskores on the CPU alone: they list CUDA among supported_device_types() but refuse its memory when asked, so every VTK algorithm on a GPU failed handing its output back. Try a small array once per type of device, and copy to the host where VTK cannot hold it.
This was referenced Nov 6, 2026
berkgeveci
added a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the Tack fixes from the 0.7 rounds on the Mac (CPU and Metal) and on jura (CUDA). Tack itself had no other failures: every other failure was in a test script or an example port.
The commits
test_arrays_protocol: the permutation's ids first. This was found on both machines.test_implicit_arrays_index_from_the_host_as_arrays_do(from f312f1c) builtPermutation(stored, ids), but the signature is(ids, base). So float values became ids, read past the three-element id array.TACK_DEBUG=1caught it. CI never runs debug mode.Permutationtakes float ids without complaint; that's unchanged here..foam. This is jura's 87b3a01._vtk_data.pathforOpenFOAM/<case>/<case>.foamfetched only that empty file. On a machine without VTK's data, the reader then had no case.dlpack_support.supported_device_types(), and refuse CUDA memory only when asked._vtk_holds), and copies to the host where VTK can't hold the memory. The two interop tests that assumed device memory skip on such a VTK.test_vtk_*.pytests and failures of examples 50-53 on CUDA to all passing. The local CUDA VTK with Viskores' device arrays still shares without a copy (212 passed).The rounds
The Mac (
mainat dc4ca7a):TACK_DEBUG=1timingmkdocs build --strict, lintround07.pyon all 11 real datasets, CPU against Metaljura: CUDA, every dataset. The details are in the vault's jura ticket.
On this branch:
test_vtk_interop.pyandtest_arrays_protocol.pypass (44 passed), examples 51 and 52 pass, and lint and the changelog check are clean.🤖 Generated with Claude Code