Repository navigation
Algorithms over pieces take MPI ranks that hold no pieces - #365
Merged
Merged
Conversation
A reader that gives some ranks nothing makes ranks without pieces. Each rank must make the same calls that communicate, so none may decide from its own pieces alone what the others decide from theirs. - probe of pieces or an AMR hierarchy, streamlines and advect over pieces, voxelize, and Advection (with the path filters) refused or failed on a rank without pieces, leaving the others waiting. Such a rank now takes part through a piece of nothing (_common._stand_in): its points and seeds go to the pieces that hold them and the answers come back. - update_ghosts, extract_surface of pieces, AMR ghost_cells and average_down, integrate over pieces, and the VTK Statistics, Entropy and Integrate algorithms chose their fields, or a shortcut, from this rank's pieces; a rank without any now gets the others' choice. - merge_pieces onto a root rank without pieces is made on the first rank that has pieces and moved to the root. test_empty_ranks.py runs 36 cases (pieces, AMR hierarchies, octrees, advection, VTK algorithms) on 3 ranks with the pieces on one, two or none of them, against the same pieces in one process; CI's MPI job runs it.
berkgeveci
force-pushed
the
mpi/empty-ranks
branch
from
November 5, 2026 19:40
7615087 to
5874013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reader that gives some ranks nothing leaves those ranks without pieces. Every rank must make the same communicating calls, so no rank may decide from its own pieces alone what the others decide from theirs. Algorithms that did either refused on such a rank or hung the job.
Fixed
probeof pieces or an AMR hierarchy,streamlinesandadvectover pieces,voxelize, andAdvection(with the path filters). Such a rank now takes part through a piece of nothing (_common._stand_in): its points and seeds go to the pieces that hold them, and the answers come back.update_ghosts,extract_surfaceof pieces, AMRghost_cellsandaverage_down,integrateover pieces, and the VTKStatistics,EntropyandIntegratealgorithms. A rank without any now gets the others' choice. The VTKIntegratealso takes one origin for the centroid over every rank.merge_piecesonto a root rank without pieces refused. The merge is now made on the first rank that has pieces and moved to the root.Test
test_empty_ranks.pyruns_empty_ranks_mpi.pyundermpiexec -n 3. It has 36 cases: pieces, AMR hierarchies, octrees, advection and the VTK algorithms over pieces. They run with four pieces on rank 0 only, on ranks 1 and 2, on ranks 0 and 1, and on none. Each answer is held to the same pieces in one process.Not fixed: an error only the ranks with data can detect (a scalar field given as a velocity) still leaves the others waiting (#364, 0.8).
Tests:
test_empty_ranks.py(4 layouts), the touched modules' tests with their MPI ones (672 passed), the quick tier (3,124), lint.🤖 Generated with Claude Code