Ask which side of the confidence threshold a delete of every listed type reaches - #1942
Closed
mattdawkins wants to merge 2 commits into
Closed
mattdawkins wants to merge 2 commits into
mattdawkins wants to merge 2 commits into
Conversation
Only the type list asked; the track list's trash button (sidebar and bottom bar) deleted the listed tracks outright. The dialog is now a shared component.
Member
Author
|
Superseded by #1944: the question belongs on the track list, not the type list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every type shown in the type list is selected and the delete button is pressed, a dialog now asks whether to delete tracks above the current confidence threshold (what the list shows, the previous behaviour), below it (the tracks the list hides), or all of them regardless of threshold. Partial selections and the group list keep the plain confirmation.
BaseFilterControls.removeTypeAnnotationsByThreshold(types, scope):abovedelegates to the existing visible-list removal;below/allwalk every annotation and remove the type only where its confidence is under that type's threshold, or everywhere, deleting the track when no type remains.Unit tests for the three scopes and for the dialog gating; docs updated.
Follow-up: the track list's delete button (sidebar and bottom bar) asks the same question when every listed track is checked — above = the listed tracks, below = tracks of the enabled types hidden by the thresholds, all = both. The dialog moved into a shared
DeleteAllScopeDialog; spec added.🤖 Generated with Claude Code