Navigate a detection's polygons from either stereo camera - #1939
Open
mattdawkins wants to merge 2 commits into
Open
mattdawkins wants to merge 2 commits into
mattdawkins wants to merge 2 commits into
Conversation
Right-clicking a polygon of the selected detection on a camera that is not selected now selects that camera and switches polygons there, the same way box and vertex drags already do.
Entering polygon mode selected the empty key, so a keyed mask (SegmentationPolygon) was not found and the editor started a new polygon. The stereo-segmented copy now shares the source polygon's key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit handles, the mousedown camera switch and the commit routing from #1737 are already geometry-agnostic, so dragging a polygon vertex or a head/tail endpoint on the non-selected camera already commits to that camera, like boxes. What was still gated to the selected camera was polygon navigation:
polygon-edit-right-click) now selects that camera and switches to the clicked polygon there, instead of being ignoredPoint-click segmentation keeps its own cross-camera path and is unchanged.
To try: select a detection present on both cameras, enter polygon editing, then on the other camera drag a vertex, right-click a second polygon of the same detection, and drag a head/tail point in line mode.
SegmentationPolygon) instead of the empty key, so its vertices are editable at once rather than after a right-click; the stereo-segmented copy shares the source polygon's key so this holds on both cameras. Specs added.🤖 Generated with Claude Code