Skip to content

Cover the filename display following the selected camera #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattdawkins wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cover the filename display following the selected camera #1933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
554e4c1
Name the selected camera beside the filename in multi-camera datasets
mattdawkins Sep 17, 2026
c71a72b
Show the selected camera's filename without a camera prefix
mattdawkins Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions client/src/components/controls/FileNameTimeDisplay.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// @vitest-environment jsdom
/* eslint-disable @typescript-eslint/no-explicit-any -- vue-test-utils typing of defineComponent */
import { ref, shallowRef } from 'vue';
import { mount } from '@vue/test-utils';
import FileNameTimeDisplay from './FileNameTimeDisplay.vue';

const selectedCamera = ref('left');
const cameras = ref(['left', 'right']);
const controllers = {
left: { filename: ref('f0028.jpg'), duration: ref(0) },
right: { filename: ref('f0028.jpg'), duration: ref(0) },
};
vi.mock('../../provides', () => ({ useSelectedCamera: () => selectedCamera }));
vi.mock('../annotators/useMediaController', () => ({
injectAggregateController: () => shallowRef({
currentTime: ref(0),
frame: ref(0),
cameras,
getController: (camera: string) => controllers[camera as 'left' | 'right'],
}),
}));

it('shows the selected camera filename', async () => {
const wrapper = mount(FileNameTimeDisplay as any, { propsData: { displayType: 'filename' } });
expect(wrapper.text()).toContain('f0028.jpg');
selectedCamera.value = 'right';
controllers.right.filename.value = 'f0029.jpg';
await wrapper.vm.$nextTick();
expect(wrapper.text()).toContain('f0029.jpg');
expect(wrapper.text()).not.toContain('f0028.jpg');
});
Loading