Finalize the detection and select the camera on a right-click in another camera - #1931
Open
mattdawkins wants to merge 2 commits into
Open
mattdawkins wants to merge 2 commits into
mattdawkins wants to merge 2 commits into
Conversation
…lready ended editing With the detection on both cameras (line mode after a stereo warp), the clicked camera's edit layer ends editing first, which left it selected and needed a second right-click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-clicking off a detection in another camera while editing selected that camera but left the detection in edit mode.
When the track also has geometry on the clicked camera (e.g. a stereo-warped detection), that camera's edit layer ends editing on the GeoJS click, which fires before the wrapper's
mouseup.changeCamerathen saweditingTrack === falseandselectCamera(camera, true)re-entered edit mode.Record the editing state on right
mousedown; if editing was active, finalize and select the clicked camera without re-entering edit mode. The still-editing case now also selects the camera instead of only deselecting.Follow-up: the press now always deselects, in every edit mode. In line mode after a stereo warp the clicked camera's edit layer had already ended editing, so the detection stayed selected and needed a second right-click.
🤖 Generated with Claude Code