-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to Resonant v0.50.3 #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianhelba
wants to merge
1
commit into
main
Choose a base branch
from
resonant-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/docker-existing-docker-compose | ||
| { | ||
| "name": "bats-ai", | ||
| "dockerComposeFile": [ | ||
| "../docker-compose.yml", | ||
| "../docker-compose.override.yml", | ||
| "./docker-compose.devcontainer.yml" | ||
| ], | ||
| "service": "django", | ||
| "overrideCommand": true, | ||
| // The "vscode" user and remoteUser are set by the base image label (devcontainers/base). | ||
| "workspaceFolder": "/home/vscode/bats-ai", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/git-lfs:1": {}, | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "ghcr.io/rails/devcontainer/features/postgres-client:1": { | ||
| "version": 18 | ||
| }, | ||
| "ghcr.io/devcontainers/features/terraform:1": {}, | ||
| "ghcr.io/devcontainers/features/aws-cli:1": {}, | ||
| "ghcr.io/devcontainers/features/github-cli:1": {}, | ||
| "ghcr.io/devcontainers-extra/features/heroku-cli:1": {} | ||
| }, | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| // Python | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance", | ||
| "ms-python.debugpy", | ||
| "ms-python.mypy-type-checker", | ||
| "charliermarsh.ruff", | ||
| // Django | ||
| "batisteo.vscode-django", | ||
| "augustocdias.tasks-shell-input", | ||
| // Other file formats | ||
| "editorconfig.editorconfig", | ||
| "mikestead.dotenv", | ||
| "tamasfe.even-better-toml", | ||
| "timonwong.shellcheck", | ||
| // Infrastructure | ||
| "ms-azuretools.vscode-containers", | ||
| "hashicorp.terraform", | ||
| "github.vscode-github-actions", | ||
| // Remove AWS extension, as only the CLI is wanted; see: https://github.com/devcontainers/features/issues/1228 | ||
| "-AmazonWebServices.aws-toolkit-vscode" | ||
| ], | ||
| "settings": { | ||
| "containers.containerClient": "com.microsoft.visualstudio.containers.docker", | ||
| // Container-specific Python paths | ||
| "python.defaultInterpreterPath": "/home/vscode/venv/bin/python", | ||
| // Ensure that `envFile` from any user settings is ignored; Docker Compose provides it. | ||
| "python.envFile": "", | ||
| // Reduce file watcher overhead for generated/cache directories. | ||
| "files.watcherExclude": { | ||
| "**/__pycache__/**": true, | ||
| "**/.pytest_cache/**": true, | ||
| "**/node_modules/**": true | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| // Prevent a prompt every time the debugger opens a port or Django auto-restarts. | ||
| "otherPortsAttributes": { | ||
| "onAutoForward": "silent" | ||
| }, | ||
| "portsAttributes": { | ||
| "8000": { | ||
| "label": "Django", | ||
| // Show a dialog if the port isn't free. | ||
| "requireLocalPort": true, | ||
| "onAutoForward": "silent" | ||
| }, | ||
| "8080": { | ||
| "label": "Vite", | ||
| "requireLocalPort": true, | ||
| "onAutoForward": "silent" | ||
| } | ||
| }, | ||
| // Install a global Python and create a venv before VSCode extensions start, | ||
| // to prevent prompts and ensure test discovery works on first load. | ||
| "onCreateCommand": { | ||
| "python": ["uv", "python", "install", "--default"], | ||
| "venv": ["uv", "sync", "--all-extras", "--all-groups"], | ||
| "npm": ["npm", "--prefix", "client", "install"] | ||
| }, | ||
| // Ensure it is re-synced on restarts. | ||
| "updateContentCommand": { | ||
| "venv": ["uv", "sync", "--all-extras", "--all-groups"], | ||
| "npm": ["npm", "--prefix", "client", "install"] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| services: | ||
| django: | ||
| # Don't expose ports, devcontainer forwarding is superior, since we can just bind to localhost. | ||
| ports: !reset [] | ||
| # Don't auto-run the default command, launch.json or the terminal will be used. | ||
| command: !reset [] | ||
|
|
||
| celery: | ||
| # Celery will be started via launch.json or the terminal. | ||
| profiles: ["celery"] | ||
|
|
||
| client: | ||
| # npm will be started via launch.json or the terminal. | ||
| profiles: ["client"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Django: Server", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/manage.py", | ||
| "args": ["runserver_plus", "--print-sql", "localhost:8000"], | ||
| "django": true, | ||
| "console": "integratedTerminal" | ||
| }, | ||
| { | ||
| "name": "Django: Server (eager Celery)", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/manage.py", | ||
| "args": ["runserver_plus", "--print-sql", "localhost:8000"], | ||
| "env": { | ||
| "DJANGO_CELERY_TASK_ALWAYS_EAGER": "true" | ||
| }, | ||
| "django": true, | ||
| "console": "integratedTerminal" | ||
| }, | ||
| { | ||
| "name": "Django: Management Command", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "program": "${workspaceFolder}/manage.py", | ||
| "args": ["${input:managementCommand}"], | ||
| "django": true, | ||
| "console": "integratedTerminal" | ||
| }, | ||
| { | ||
| "name": "Celery: Worker", | ||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "module": "celery", | ||
| "args": [ | ||
| "--app", | ||
| "bats_ai.celery", | ||
| "worker", | ||
| "--loglevel", | ||
| "INFO", | ||
| "--pool", | ||
| "solo", | ||
| "--without-heartbeat" | ||
| ], | ||
| "console": "integratedTerminal", | ||
| "justMyCode": false | ||
| }, | ||
| { | ||
| "name": "Pytest: Debug", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test breakpoints weren't working for Bryon for some reason. |
||
| "type": "debugpy", | ||
| "request": "launch", | ||
| "purpose": ["debug-test"], | ||
| "console": "integratedTerminal", | ||
| "django": true, | ||
| "justMyCode": false | ||
| }, | ||
| { | ||
| "name": "Vite: Dev Server", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "cwd": "${workspaceFolder}/client", | ||
| "runtimeExecutable": "npm", | ||
| "runtimeArgs": ["run", "dev"], | ||
| "console": "integratedTerminal" | ||
| } | ||
| ], | ||
| "compounds": [ | ||
| { | ||
| "name": "Django + Celery", | ||
| "configurations": ["Django: Server", "Celery: Worker"], | ||
| "stopAll": true | ||
| }, | ||
| { | ||
| "name": "Django + Celery + Vite", | ||
| "configurations": ["Django: Server", "Celery: Worker", "Vite: Dev Server"], | ||
| "stopAll": true | ||
| } | ||
| ], | ||
| "inputs": [ | ||
| { | ||
| "id": "managementCommand", | ||
| "type": "command", | ||
| "command": "shellCommand.execute", | ||
| "args": { | ||
| "command": "./manage.py help --commands", | ||
| "description": "Django management command", | ||
| "allowCustomValues": true | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| // File cleanup | ||
| "files.trimTrailingWhitespace": true, | ||
| "files.insertFinalNewline": true, | ||
| "files.trimFinalNewlines": true, | ||
|
|
||
| // Python | ||
| "python.analysis.autoFormatStrings": true, | ||
| "python.testing.pytestEnabled": true, | ||
| "python.analysis.autoImportCompletions": true, | ||
| "python.analysis.gotoDefinitionInStringLiteral": true, | ||
| // Allow auto-importing from deeper symbols inside of Django. | ||
| "python.analysis.packageIndexDepths": [ | ||
| { | ||
| "name": "django", | ||
| "depth": 6 | ||
| } | ||
| ], | ||
| "python.analysis.inlayHints.pytestParameters": true, | ||
|
|
||
| // Django templates | ||
| "emmet.includeLanguages": { | ||
| "django-html": "html" | ||
| }, | ||
|
|
||
| // Type checking: Use Mypy and disable Pylance. | ||
| "mypy-type-checker.importStrategy": "fromEnvironment", | ||
| // Mypy daemon seems better, but is buggy in practice. | ||
| "mypy-type-checker.preferDaemon": false, | ||
| "mypy-type-checker.reportingScope": "file", | ||
| "python.analysis.typeCheckingMode": "off", | ||
|
|
||
| // Ruff | ||
| "[python]": { | ||
| "editor.defaultFormatter": "charliermarsh.ruff" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't work unless we bind to 0.0.0.0.