Merged
Conversation
BryonLewis
previously requested changes
Apr 7, 2026
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
More like comments I want feedback on than changes.
- Questions about using the vite standard (
npm run dev,npm run previewinstead of oldervue-cli-servicecommands). - Configuration changes to make it easier to do local dev and testing of the client outside of docker without having to specify a .env file or env variables inline. This may be a selfish request for myself to make debugging things a bit easier.
Deploying bats-ai with
|
| Latest commit: |
d2cbfaa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://210ca174.bats-ai.pages.dev |
| Branch Preview URL: | https://vite-8.bats-ai.pages.dev |
Member
Author
|
@BryonLewis Responded to your feedback, adding a |
BryonLewis
approved these changes
Apr 10, 2026
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
Looks good.
Checked that I can still source the environment file and npm run build and npm run preview to test for any vite/maplibre issues easily without modifying additional configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates the TypeScript config from upstream
create-vue-app, so new type errors are detected.Note, for better consistency with other tools, the npm commands are now:
npm run servenpm run testFinally, this adds a build-time sanity check (since TypeScript alone can't actually guarantee that environment variables are set), to prevent regressions like #463. Now that
VITE_APP_API_ROOTis always defined the Vite config forserver.proxycan be removed (which only affects the development server).