Skip to content

Update config for Vite v8#471

Merged
brianhelba merged 5 commits intomainfrom
vite-8
Apr 10, 2026
Merged

Update config for Vite v8#471
brianhelba merged 5 commits intomainfrom
vite-8

Conversation

@brianhelba
Copy link
Copy Markdown
Member

This also updates the TypeScript config from upstream create-vue-app, so new type errors are detected.

Note, for better consistency with other tools, the npm commands are now:

  • npm run serve
  • npm run test

Finally, this adds a build-time sanity check (since TypeScript alone can't actually guarantee that environment variables are set), to prevent regressions like #463. Now that VITE_APP_API_ROOT is always defined the Vite config for server.proxy can be removed (which only affects the development server).

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like comments I want feedback on than changes.

  • Questions about using the vite standard (npm run dev, npm run preview instead of older vue-cli-service commands).
  • Configuration changes to make it easier to do local dev and testing of the client outside of docker without having to specify a .env file or env variables inline. This may be a selfish request for myself to make debugging things a bit easier.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 10, 2026

Deploying bats-ai with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2cbfaa
Status: ✅  Deploy successful!
Preview URL: https://210ca174.bats-ai.pages.dev
Branch Preview URL: https://vite-8.bats-ai.pages.dev

View logs

@brianhelba brianhelba requested a review from BryonLewis April 10, 2026 13:16
@brianhelba brianhelba dismissed BryonLewis’s stale review April 10, 2026 13:16

Responded to feedback.

@brianhelba
Copy link
Copy Markdown
Member Author

@BryonLewis Responded to your feedback, adding a preview config block and restoring the dev and preview script names. I also rebased.

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Checked that I can still source the environment file and npm run build and npm run preview to test for any vite/maplibre issues easily without modifying additional configs.

@brianhelba brianhelba merged commit 47e96c6 into main Apr 10, 2026
4 checks passed
@brianhelba brianhelba deleted the vite-8 branch April 10, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants