Repository navigation
fix(dicomweb): handle missing and failed series metadata - #1019
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
dicomweb-metadata-failure
branch
from
November 5, 2026 23:26
3de937c to
4994b3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DICOMWeb series link starts a download even when its metadata request fails. The download then reads the missing series metadata outside its error handler, which produces an unhandled rejection and leaves the series marked Pending, so a later retry of the link never downloads it.
importMetasynchronous, and skip records that name a series without its study or an instance without its series, so a malformed record is left out of the list instead of raising an unhandled rejection.Adds an e2e spec backed by a local DICOMweb server.
This fixes behavior already present on main and is independent of #994. That refactor touches the same download function, so it will need to incorporate this fix when rebased.