Skip to content

fix(dicomweb): handle missing and failed series metadata - #1019

Merged
PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:dicomweb-metadata-failure
Nov 6, 2026
Merged

PaulHax merged 1 commit into
Kitware:mainfrom
PaulHax:dicomweb-metadata-failure

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

A DICOMWeb series link starts a download even when its metadata request fails. The download then reads the missing series metadata outside its error handler, which produces an unhandled rejection and leaves the series marked Pending, so a later retry of the link never downloads it.

  • Start the linked download only after the series metadata has been imported, and only when the response names at least one instance. An empty response keeps the existing "Found zero dicoms." message without an error notification.
  • Read the series and study metadata inside the download's error handler. A linked series that the returned metadata does not describe is reported as "Failed to load DICOM".
  • Make importMeta synchronous, and skip records that name a series without its study or an instance without its series, so a malformed record is left out of the list instead of raising an unhandled rejection.
  • When browsing a patient or study, import what each metadata request returned and report failed requests as "Failed to fetch DICOMWeb metadata". Previously a failed series metadata request left the series spinner running indefinitely.

Adds an e2e spec backed by a local DICOMweb server.

This fixes behavior already present on main and is independent of #994. That refactor touches the same download function, so it will need to incorporate this fix when rebased.

@netlify

netlify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit 4994b3c
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/6aed10aad133fef19972cb44
😎 Deploy Preview https://deploy-preview-1019--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PaulHax
PaulHax force-pushed the dicomweb-metadata-failure branch from 3de937c to 4994b3c Compare November 5, 2026 23:26
@PaulHax
PaulHax merged commit f554e6c into Kitware:main Nov 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant