Repository navigation
fix(rendering): skip deferred renders after view disposal - #1018
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
marked this pull request as ready for review
November 5, 2026 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A render queued before view disposal can still run if cleanup throws before the pending timer is cancelled. Check the disposed flag when the deferred callback executes, preventing it from rendering widgets or traversing the deleted view.
The tests use normal frozen vtk.js objects and observe their public modification/render events. A throwing view-removal listener interrupts cleanup after the OpenGL view is deleted, leaving the queued render pending. Live-view and normal-disposal cases provide controls. No constructors, render methods, or delete methods are replaced; fake timers control callback execution. These are lifecycle tests, not GPU rendering tests.
Validation: