Skip to content

Migrate to kittycad 0.4.7 API for commands_ws#1115

Merged
jtran merged 3 commits intodependabot/cargo/kittycad-0.4.7from
copilot/migrate-library-version-for-clippy
Mar 3, 2026
Merged

Migrate to kittycad 0.4.7 API for commands_ws#1115
jtran merged 3 commits intodependabot/cargo/kittycad-0.4.7from
copilot/migrate-library-version-for-clippy

Conversation

Copy link

Copilot AI commented Mar 3, 2026

The kittycad 0.4.7 upgrade introduced a breaking change: commands_ws() now accepts a single CommandsWsParams struct instead of 10 individual parameters.

Changes

  • Updated modeling-session/src/lib.rs to use CommandsWsParams struct with field initialization
  • Used ..Default::default() for unset fields (api_call_id, pool, post_effect, pr, replay, order_independent_transparency)

Before:

.commands_ws(
    None, fps, None, None, None, 
    show_grid, unlocked_framerate, 
    video_res_height, video_res_width, webrtc,
)

After:

.commands_ws(kittycad::modeling::CommandsWsParams {
    fps, show_grid, unlocked_framerate,
    video_res_height, video_res_width, webrtc,
    ..Default::default()
})

No behavioral changes—all previous parameters map directly to struct fields.

Original prompt

Pull Request: #1105

Migrate to use the new version of the library so that cargo clippy passes. Preserve all functionality from before upgrading.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 3, 2026 04:12
…0.4.7

Co-authored-by: jtran <10803+jtran@users.noreply.github.com>
Co-authored-by: jtran <10803+jtran@users.noreply.github.com>
Copilot AI changed the title [WIP] Migrate to new library version for clippy compatibility Migrate to kittycad 0.4.7 API for commands_ws Mar 3, 2026
Copilot finished work on behalf of jtran March 3, 2026 04:17
@jtran jtran marked this pull request as ready for review March 3, 2026 04:29
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dependabot/cargo/kittycad-0.4.7@ce1bd5a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-session/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##             dependabot/cargo/kittycad-0.4.7    #1115   +/-   ##
==================================================================
  Coverage                                   ?   30.09%           
==================================================================
  Files                                      ?       34           
  Lines                                      ?     1585           
  Branches                                   ?        0           
==================================================================
  Hits                                       ?      477           
  Misses                                     ?     1108           
  Partials                                   ?        0           
Flag Coverage Δ
unittests 30.09% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtran jtran merged commit 4ad64d1 into dependabot/cargo/kittycad-0.4.7 Mar 3, 2026
10 checks passed
@jtran jtran deleted the copilot/migrate-library-version-for-clippy branch March 3, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants