Safe modification to imprint API for preserved targets support#1108
Merged
adamchalmers merged 4 commits intomainfrom Mar 3, 2026
Merged
Safe modification to imprint API for preserved targets support#1108adamchalmers merged 4 commits intomainfrom
adamchalmers merged 4 commits intomainfrom
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage ? 30.03%
=======================================
Files ? 34
Lines ? 1588
Branches ? 0
=======================================
Hits ? 477
Misses ? 1111
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamchalmers
reviewed
Mar 2, 2026
modeling-cmds/src/def_enum.rs
Outdated
| @@ -2264,10 +2264,17 @@ define_modeling_cmd_enum! { | |||
| { | |||
| /// Which input bodies to intersect. Inputs with non-solid body types are permitted | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Which input bodies to intersect. Inputs with non-solid body types are permitted | |
| /// Which input bodies to intersect. Inputs with non-solid body types are permitted. These are the target IDs. |
adamchalmers
reviewed
Mar 2, 2026
modeling-cmds/src/def_enum.rs
Outdated
| pub body_ids: Vec<Uuid>, | ||
| /// Geometry to imprint from, if provided, these bodies will be unmodified and body_ids will be used as imprint targets | ||
| #[serde(default)] | ||
| pub target_ids: Option<Vec<Uuid>>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub target_ids: Option<Vec<Uuid>>, | |
| pub tool_ids: Option<Vec<Uuid>>, |
adamchalmers
force-pushed
the
mike/imprint-targets-support
branch
from
5c244ee to
3ede410
Compare
adamchalmers
force-pushed
the
mike/imprint-targets-support
branch
from
3ede410 to
8851b1e
Compare
adamchalmers
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for https://github.com/KittyCAD/engine/pull/4230