Repository navigation
Tests: Improve resource sorting assertions - #1264
Merged
Merged
Conversation
…into broadcasts-export-greeting
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
marked this pull request as ready for review
October 28, 2026 13:18
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
October 28, 2026 13:18
noelherrick
approved these changes
Oct 28, 2026
Broadcasts: Export: Use Featured Image as Thumbnail
Broadcasts: Export: Greeting, Sign-off and Read on the Web settings
Broadcasts: Export: Use Post Excerpt as Preview Text
Broadcasts: Rename Creator Profile to Newsletter site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resource tests asserted hard-coded first and last resource names, failing when the Kit test account has additional Tags, Sequences etc. (e.g.
ResourceSequencesTest::testGetWithInvalidOrderBy,RefreshResourcesButtonCest::testRefreshResourcesInClassicEditor).Mirrors the approach in
convertkit-wordpress-libraries:ResourceAssertionsTraitwithassertResourcesSorted()(sorted byorder_by/order, usingstrcmpas the resource class does) andassertResourcesInOriginalOrder()(for invalidorder_by), used by allResource*Testclasses.checkSelectFormOptionOrder(),checkSelectLandingPageOptionOrder()andcheckSelectTagOptionOrder()now assert prepended options are first and all resources are sorted, instead of checking hard-coded first / last options.Existing assertions that
.envresources exist are unchanged.Checklist