-
Notifications
You must be signed in to change notification settings - Fork 8
Tests: Fix Heartbeat Warning in Siteground Speed Optimizer #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etup-wizard-form-importers
Campaign Monitor uses e.g. `cm_123456`
…into setup-wizard-named-steps
…o importer-campaign-monitor
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
ciccio-kit
approved these changes
Feb 6, 2026
ciccio-kit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Importer: Campaign Monitor
Setup Wizard: Form Importers
Setup Wizard: Steps: Use Named Identifiers
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore the PHP notice when running tests relating to the Siteground Speed Optimizer WordPress Plugin in WordPress 6.9.1, which they seem to think is okay, and configure the Siteground Speed Optimizer to not deregister the heartbeat script.
Testing
Existing tests pass.
Checklist