Setup Wizard: Form Importers #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
…etup-wizard-form-importers
Campaign Monitor uses e.g. `cm_123456`
…o importer-campaign-monitor
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
ciccio-kit
approved these changes
Feb 6, 2026
ciccio-kit
left a comment
ciccio-kit
left a comment
There was a problem hiding this comment.
Found only one potential issue, but pre-approving. When fixed (or if not relevant), feel free to go ahead and merge ✅
| if ( array_key_exists( 'error', $request ) || array_key_exists( 'error_description', $request ) ) { | ||
| // Decrement the step. | ||
| $this->step = 'start'; | ||
| $this->error = sanitize_text_field( wp_unslash( $request['error_description'] ) ); |
There was a problem hiding this comment.
issue: based on the OR in this if there is a risk this line is reached even if there is no error_description in $request. If this is a possible scenario it should be handled safely
Importer: Campaign Monitor
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Displays a screen during the onboarding/setup wizard, prompting users to automatically replace third party forms with Kit Forms across their WordPress web site, if third party forms are detected on the site based on the current registered importers the Kit Plugin has:
Testing
testSetupWizardFormImporterScreen: Test that the Form Importer step is available when a supported third party form plugin has form(s) on the WordPress siteChecklist