Skip to content

feat(mobile): show answer-choice subtitles in the agent question card - #6096

Open
iscekic wants to merge 1 commit into
mainfrom
kwf/surface-the-mobile-app-apps-mobile-4534
Open

feat(mobile): show answer-choice subtitles in the agent question card#6096
iscekic wants to merge 1 commit into
mainfrom
kwf/surface-the-mobile-app-apps-mobile-4534

Conversation

@iscekic

@iscekic iscekic commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Changelog for users

  • Agent answer choices now show each choice description as muted supporting text beneath its label.
  • Selected choices keep both the label and description readable on filled buttons.
  • Choices without descriptions show only their labels, without an empty second line.
  • Screen readers announce a described choice's label followed by its description.
  • The approved repair changes no user-visible behavior.

Changelog for maintainers

  • The subtitle joins the accessible name (<label>, <description>) instead of accessibilityHint, because TalkBack reads hint text and ignores the tooltip React Native fills from accessibilityHint.
  • A choice without a description keeps its bare label as the accessible name and sets no hint.
  • Label and subtitle use a full-width column inside the option button, preserving its existing height, padding, and selected background.
  • The subtitle uses a smaller muted style and a translucent foreground color on the selected filled button.
  • The feature reuses existing option and option-selected translations with the composed label; it adds no copy or catalog keys.
  • Unit tests cover subtitle rendering, the no-description branch, and the accessible-name/no-hint contract.
  • Review the option button first because accessible naming and selected contrast are risky; feature evidence collected on 2026-09-12 does not establish visual legibility.
  • .kwf-keep-device: accepted — the unreferenced zero-byte artifact was removed. Replacement evidence from 2026-09-12 replaces repair-specific runtime proof: it shows no runtime change, so no live proof applies to the repair. Feature captures remain unaffected.

E2E proof

scripted-shard1.mp4.trim.mp4

[p3] With VoiceOver/TalkBack enabled, focusing a described option announces the option label followed by its description as the hint. — e2e-mobile-app/p3.png

[p3] With VoiceOver/TalkBack enabled, focusing a described option announces the option label followed by its description as the hint. — prior/p3-talkback.png

[p1] Open a cloud-agent session that asks a question whose options carry descriptions; each choice button shows the label on top with the muted description underneath, and the card scrolls/CTAs stay… — prior/p1sel.png

[p2] In the same card, an option with an empty description shows only its label (no blank second line), and selecting a described option keeps both lines legible on the filled-primary button. — prior/p2-select.png

[p2] In the same card, an option with an empty description shows only its label (no blank second line), and selecting a described option keeps both lines legible on the filled-primary button. — e2e-mobile-app/p2.png

Owner request

Surface: the mobile app (apps/mobile).

The question tool should support a subtitle for the answer choices, same as the CLI.

@kilo-code-bot

kilo-code-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/mobile/src/components/agents/question-card.tsx
  • apps/mobile/src/components/agents/question-card.mounted.test.tsx
Previous Review Summary (commit bd2261b)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit bd2261b)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The question-card subtitle change is sound; the only finding is a stray empty .kwf-keep-device workflow artifact committed at the repo root.

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
.kwf-keep-device n/a Zero-byte file added by this PR, absent from main, and referenced by no code/config in the repo. It looks like a local Kilo workflow/emulator keepalive artifact. Remove it unless the e2e tooling intentionally requires it in-tree.
Files Reviewed (3 files)
  • .kwf-keep-device - 1 issue
  • apps/mobile/src/components/agents/question-card.tsx - 0 issues
  • apps/mobile/src/components/agents/question-card.mounted.test.tsx - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic marked this pull request as draft September 12, 2026 09:10
@iscekic

iscekic commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

bot: Rejected, no code change (kwf kwf-fix-review-a58b).

Why: (no PR: the branch changes no line

@iscekic
iscekic force-pushed the kwf/surface-the-mobile-app-apps-mobile-4534 branch from dedd69c to fd5d5d9 Compare September 12, 2026 11:47
@iscekic

iscekic commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

bot: Rejected, no code change (kwf kwf-fix-review-a58b).

Why: (no PR: the branch changes no line

@iscekic
iscekic marked this pull request as ready for review September 12, 2026 11:57
@iscekic
iscekic requested a review from eshurakov September 12, 2026 12:08
@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 12, 2026
@iscekic iscekic self-assigned this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant