fix(auth): mark system tokens as non-exchangeable - #5806
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryPhase 3 marks all 14 system-token issuance sites with Files Reviewed (8 files)
Reviewed by grok-4.6 · Input: 76K · Output: 9.9K · Cached: 213.2K Review guidance: REVIEW.md from base branch |
iscekic
approved these changes
Sep 1, 2026
pandemicsyn
enabled auto-merge (squash)
September 1, 2026 19:08
pandemicsyn
disabled auto-merge
September 1, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark tokens created at 14 internal issuance sites so they cannot be exchanged for persistent user login credentials through native exchange:
tokenSource: "app-builder".generateCloudAgentTokenhelper.tokenSource: "security-agent".This applies the exchange restrictions introduced by merged #5785 and #5786 without changing token lifetimes or ordinary service authentication. The PR targets
mainand contains only the Phase 3 changes.Verification
No manual runtime or browser tests were performed. These are backend credential changes with no visual behavior changes; actual issuer flows and native exchange were exercised through automated integration tests instead of using live credentials or production services. Automated results are listed under Reviewer Notes.
Visual Changes
N/A
Reviewer Notes
Automated validation after merging current main and resolving conflicts without rewriting published history:
pnpm --filter web lintpassed.pnpm --filter web typecheckpassed, with existing declaration-bundling external-dependency warnings.