docs(app-builder): add architecture doc explaining framework support and deployment pipeline#1763
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
docs(app-builder): add architecture doc explaining framework support and deployment pipeline#1763kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
…and deployment pipeline Documents the full App Builder lifecycle (preview vs deploy), the gap between detected and deployable project types, and why Vite projects fail to deploy despite working in preview.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| 4. The preview is served through an iframe proxy that injects a bridge script | ||
| for navigation tracking. | ||
|
|
||
| Because the preview runs `bun run dev`, **any framework with a valid `dev` |
Contributor
Author
There was a problem hiding this comment.
WARNING: Preview support is narrower than this sentence says
PreviewDO always runs bun install --frozen-lockfile before starting the dev server and the proxy only forwards to port 8080 (cloudflare-app-builder/src/preview-do.ts:420, cloudflare-app-builder/src/handlers/preview.ts:287). A project can have a valid dev script and still fail preview if Bun install fails or the server does not bind to that port, so this wording overstates what the preview layer guarantees.
Contributor
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 616,969 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/app-builder-architecture.mddocumenting the full App Builder lifecycle, specifically addressing why Vite projects fail to deploy while working in preview.Key findings documented:
bun run devin a Cloudflare Sandbox, so any framework with a validdevscript works (including Vite)supportedProjectTypeSchema, which only includes 6 of the 15 detectable types:nextjs,astro,hugo,jekyll,eleventy,plain-htmldetect-project.sh) but rejected at deploy time because no build pipeline exists for itVerification
supportedProjectTypeSchemavalues match what's incloudflare-deploy-infra/builder/src/types.tsdetect-project.shdetection order and project type listdeployment-orchestrator.tsVisual Changes
N/A
Reviewer Notes
This is a documentation-only change. The doc is placed in
docs/alongside the existingdo-sqlite-drizzle.mdconvention. It serves as both internal architecture reference and investigation notes for the user-reported issue of Vite projects failing to deploy.