feat(cloud-agent): improve topbar, mobile UX, and session management#1677
Merged
feat(cloud-agent): improve topbar, mobile UX, and session management#1677
Conversation
Contributor
Code Review SummaryStatus: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)The incremental diff fixes the previous sidebar ordering warning in Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Fix these issues in Kilo Cloud Files Reviewed (1 file)
Reviewed by gpt-5.4-20260305 · 135,456 tokens |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
- Add mobile toolbar popover and constrain popover widths to viewport - Left-align topbar title and improve mobile session list button - Show app topbar with session context on cloud pages - Improve new session UX and filter child sessions
eshurakov
force-pushed
the
eshurakov/cloud-agent/top-bar-and-prompt
branch
from
595b1dd to
5c62c3a
Compare
eshurakov
changed the title
eshurakov
commented
Mar 30, 2026
Contributor
Author
There was a problem hiding this comment.
I'm reverting this because my previous PR changed it and it wasn't needed
Long-lived sessions updated recently were disappearing from the sidebar because the cutoff filtered on created_at while grouping uses updatedAt.
Contributor
I don't see repo in the screenshot? |
markijbema
reviewed
Mar 31, 2026
markijbema
reviewed
Mar 31, 2026
markijbema
approved these changes
Mar 31, 2026
…query keys Replace server-computed recentDays with client-computed updatedSince ISO datetime. This produces a stable tRPC query key per mount, improving react-query cache hit rates.
…ssion lifecycle Thread githubRepo, gitUrl, and platform through registerSession so early metadata reflects the git source. Emit branch name in the 'ready' preparing event and update fetchedSessionData on the client so the UI shows the correct branch immediately after async preparation completes.
… appear first The unifiedSessions.list endpoint defaults orderBy to created_at. The sidebar filters by updatedSince but never overrode the sort order, so a long-lived session that just became active would still sort below newer inactive sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the cloud agent pages with the shared app topbar, adds mobile-responsive toolbar controls, and improves the new-session UX.
Topbar integration: Cloud agent pages now use the shared
AppTopbarinstead of hiding it. The session title (or repo name) and cost display are rendered in the topbar.ChatHeaderis stripped down to floating action buttons (sound, menu, feedback) positioned top-right.Mobile toolbar: Below the
mdbreakpoint, the individual Mode/Model/Variant pickers collapse into a singleMobileToolbarPopover. Popover widths are clamped tomin(Xrem, calc(100vw - 2rem))to prevent overflow on small screens. AMobileSidebarTogglebutton replaces the old hamburger menu for opening the session list on mobile.New session UX: The most recent repo is auto-selected. Repo selection is no longer required to start a session (shows an error toast instead). The new-session panel gets the same mobile toolbar treatment.
Auto-scroll: Programmatic scrolls are distinguished from user scrolls via
isAutoScrollingRef. Rapid streaming updates are coalesced withrequestAnimationFrame. Scrolling up disables auto-scroll; scrolling near bottom re-enables it. Session switches reset scroll state.Child session filtering: Sessions with a
parentSessionIdare excluded from the active sessions list inUserConnectionDO. Protocol schema updated with tests.CSS:
scrollbar-gutter: stableapplied globally instead of desktop-only.Verification
Visual Changes
Reviewer Notes
PageTitleContextno longer exposeshidden/setHidden— cloud agent pages now always show the topbar.ChatHeaderlost most of its content (repo, branch, model, cost) since that info moved to the topbar and inline areas. It now only renders action buttons.md(768px). The sidebar toggle breakpoint islg(1024px).