Wait for first video frame in texture-srgb-upload.html - #3788
Merged
Conversation
Unlike other WebGL video tests, texture-srgb-upload.html previously called await video.play() without waiting for requestVideoFrameCallback or using wtu.waitVideoUploadable(video). On slow or asynchronous hardware decoders, texImage2D(..., video) could upload before the first frame was ready, reading all zeros ([0, 0, 0, 0]). Use await wtu.waitVideoUploadable(video) before running texture upload tests to prevent this race condition, matching the standard idiom used in tex-image-and-sub-image-2d-with-video.js and other video tests.
|
|
Contributor
Author
|
cc @kenrussell Could you take a look at this change. I believe this change can fix this test failure on both android and fuchsia. |
Contributor
Author
|
During Ken's OOO, @toji , can you take a look at this change? Thank you. |
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike other WebGL video tests, texture-srgb-upload.html previously called await video.play() without waiting for requestVideoFrameCallback or using wtu.waitVideoUploadable(video). On slow or asynchronous hardware decoders, texImage2D(..., video) could upload before the first frame was ready, reading all zeros ([0, 0, 0, 0]).
Use await wtu.waitVideoUploadable(video) before running texture upload tests to prevent this race condition, matching the standard idiom used in tex-image-and-sub-image-2d-with-video.js and other video tests.