Skip to content

Use proper API version defines #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaschaWillems wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use proper API version defines #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions en/12_Ecosystem_Utilities_and_Compatibility.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ The first step is to detect what features are available on the user's GPU. This
bool dynamicRenderingSupported = false;

// Check for Vulkan 1.3 support
if (deviceProperties.apiVersion >= VK_VERSION_1_3) {
if (deviceProperties.apiVersion >= VK_API_VERSION_1_3) {
dynamicRenderingSupported = true;
} else {
// Check for the extension on older Vulkan versions
Expand Down Expand Up @@ -419,7 +419,7 @@ Timeline semaphores (introduced in Vulkan 1.2) provide a more flexible synchroni
bool timelineSemaphoresSupported = false;

// Check for Vulkan 1.2 support or extension
if (deviceProperties.apiVersion >= VK_VERSION_1_2) {
if (deviceProperties.apiVersion >= VK_API_VERSION_1_2) {
timelineSemaphoresSupported = true;
} else {
// Check for extension
Expand Down Expand Up @@ -471,7 +471,7 @@ The Synchronization2 feature (Vulkan 1.3) simplifies pipeline barriers and memor
bool synchronization2Supported = false;

// Check for Vulkan 1.3 support or extension
if (deviceProperties.apiVersion >= VK_VERSION_1_3) {
if (deviceProperties.apiVersion >= VK_API_VERSION_1_3) {
synchronization2Supported = true;
} else {
// Check for extension
Expand Down
2 changes: 1 addition & 1 deletion en/13_Vulkan_Profiles.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ In the previous chapter, we had to write code like this for *each feature* we wa
bool dynamicRenderingSupported = false;

// Check for Vulkan 1.3 support
if (deviceProperties.apiVersion >= VK_VERSION_1_3) {
if (deviceProperties.apiVersion >= VK_API_VERSION_1_3) {
dynamicRenderingSupported = true;
} else {
// Check for the extension on older Vulkan versions
Expand Down
Loading