Adjust library type back to "object" when compiling locally - #1561
Open
SaschaWillems wants to merge 1 commit into
Open
Adjust library type back to "object" when compiling locally#1561SaschaWillems wants to merge 1 commit into
SaschaWillems wants to merge 1 commit into
Conversation
Band-aid fix Refs #1555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a band-aid fix for excessive build sizes and does not fix the fundamental structural issues of the samples/framework.
This reverts back the library type to object when building locally (=lower build size) and sticks with static when building inside the github CI (=still works with the MSVC CLI 32-bit address space limiation).
General Checklist:
Please ensure the following points are checked: