Skip to content

Adjust library type back to "object" when compiling locally - #1561

Open
SaschaWillems wants to merge 1 commit into
mainfrom
build_size_fix
Open

Adjust library type back to "object" when compiling locally#1561
SaschaWillems wants to merge 1 commit into
mainfrom
build_size_fix

Conversation

@SaschaWillems

@SaschaWillems SaschaWillems commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Description

This is a band-aid fix for excessive build sizes and does not fix the fundamental structural issues of the samples/framework.

This reverts back the library type to object when building locally (=lower build size) and sticks with static when building inside the github CI (=still works with the MSVC CLI 32-bit address space limiation).

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

@SaschaWillems SaschaWillems added the build This is relevant to the build system label Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build This is relevant to the build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant