Add simultaneous update capability#1466
Add simultaneous update capability#1466joselopeqti wants to merge 2 commits intoKhronosGroup:mainfrom
Conversation
|
Thanks for opening this, it's important to clarify to users if this is allowed, as it's an important use case to enable. The current CTS test for non simultaneous-use workflow uses simultaneous-update behaviour by calling update without a blocking wait on the previous command-buffer enqueue. So all cl_khr_command_buffer_mutable_dispatch implementations that currently run and pass the It would be interesting if that's been painful for any vendors and we should have this optional capability for simultaneous-update, or we can just make simultaneous-update required functionality for the extension and better specify that it is allowed. |
This PR addresses #1465.
It follows a similar pattern to the one used for simultaneous update #1411.
It adds the
CL_COMMAND_BUFFER_CAPABILITY_SIMULTANEOUS_UPDATE_KHRcapability, which allows developers to query if the implementation supports updating a command-buffer while an instance of the same is being ran.If the capability is not supported, applications must wait for all previous submissions of the command-buffer to be finished before calling
clUpdateMutableCommandsKHR.It also fixes a wrong
ifdefthat was checking forcl_khr_command_buffer_multi_deviceinstead ofcl_khr_command_buffer_mutable_dispatch.