improve error code consistency, part one#1399
Draft
bashbaug wants to merge 28 commits intoKhronosGroup:mainfrom
Draft
improve error code consistency, part one#1399bashbaug wants to merge 28 commits intoKhronosGroup:mainfrom
bashbaug wants to merge 28 commits intoKhronosGroup:mainfrom
Conversation
github-project-automation
bot
moved this to In progress
in OpenCL specification maintenance
Contributor
Author
|
Now that v3.0.19 is published I'd like to start getting these changes over the finish line. Would it be helpful to break this PR into smaller pieces? If so, what is the right size? One PR per API is probably a bit too fine-grained since there are over 100 APIs. Maybe one PR per "chapter"? Or, is this PR tractable as-is, and folks just need a bit more time for review? |
Contributor
Author
|
I'll break this PR into smaller pieces for easier review. Moving to "draft" so it doesn't get accidentally merged. |
This was referenced Aug 14, 2025
This was referenced Aug 26, 2025
This was referenced Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to partially address the way we document error conditions, see #1320 and in particular #1320 (comment).
This doesn't modify the entire spec, but:
We should decide whether we merge these changes in their partial state or whether we wait to review and merge the changes for the entire spec in the same PR.
Regardless, it would be beneficial to decide what to do with this PR sooner rather than later, because any changes to error conditions will likely result in merge conflicts that will need to be resolved.